Repository navigation
Release completed webview message reply callbacks - #9050
Open
Henning Dieterichs (hediet) wants to merge 1 commit into
Open
Henning Dieterichs (hediet) wants to merge 1 commit into
Henning Dieterichs (hediet) wants to merge 1 commit into
Conversation
Use a Map for pending replies, delete entries before settling replies or after a send failure, and ignore late replies instead of dispatching them as commands. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot started reviewing on behalf of
Henning Dieterichs (hediet)
October 9, 2026 17:04
View session
This was referenced Oct 9, 2026
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused implementation matches the stated behavior and includes adequate regression coverage.
0 open findings
What changed in this PR
Updates webview request handling to release completed reply callbacks promptly.
Changes:
- Stores pending replies in a
Mapand removes them before settlement. - Cleans up synchronous send failures and ignores duplicate or unknown replies.
- Adds regression coverage for success, rejection, cleanup, and command routing.
| File | Description |
|---|---|
webviews/common/message.ts |
Implements pending-reply lifecycle cleanup. |
webviews/common/test/message.test.ts |
Tests reply cleanup and routing behavior. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Eleanor Boyd (eleanorjboyd)
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Release message reply callbacks as soon as each request completes instead of retaining them for the lifetime of the webview.
This is a standalone fix against main, extracted from #9047 to keep that PR focused on host/context ownership. No host injection, singleton removal, or Component Explorer tooling is included here.
Validation
npm run test:webviews: build succeeded; 65 tests passed, including two new cleanup regressions.npm run lintandnpm run hygienepassed.