You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi Artur, thanks for the template, the DI setup is clean. A structural check I maintain flags that the deck/card write routes reach the DB without an auth dependency (https://wyro.in/scan/modern-python/fastapi-sqlalchemy-template). For a template I assume that's deliberate, to keep it minimal. Would a commented auth dependency on one route be welcome as a PR, or is it out of scope? Happy either way.
Hi Dominic, thanks for the kind words and for asking first.
Yes, it's deliberate. The template is meant to show the DI wiring, the SQLAlchemy setup and the test isolation. Auth depends on the project (JWT, sessions, an API gateway in front, mTLS between services), so any single choice would be wrong for a good share of users. A commented-out dependency would also go stale, since nothing would run or test it.
I'm adding a line to the readme saying auth is intentionally omitted, so the next reader doesn't have to wonder (#68). Closing as out of scope.
Activity
lesnik512 commentedon Sep 27, 2026
Hi Dominic, thanks for the kind words and for asking first.
Yes, it's deliberate. The template is meant to show the DI wiring, the SQLAlchemy setup and the test isolation. Auth depends on the project (JWT, sessions, an API gateway in front, mTLS between services), so any single choice would be wrong for a good share of users. A commented-out dependency would also go stale, since nothing would run or test it.
I'm adding a line to the readme saying auth is intentionally omitted, so the next reader doesn't have to wonder (#68). Closing as out of scope.