Repository navigation
fix: silence ty 0.0.87 override checks on instrument bootstrap_config - #284
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #283.
The scheduled dependency check picked up ty 0.0.87, which turns on
invalid-mutable-overrideby default. Every framework instrument narrowsbootstrap_configfrom its base instrument's config type, for exampleFastAPIConfigoverLoggingConfig. That gives 25 errors.This PR is the quick fix: one
# ty: ignore[invalid-mutable-override]per line. The proper fix is to make the instruments generic over their config type. That touches every instrument, so it will get its own issue.It also widens the build backend pin from
uv_build<0.12touv_build>=0.11,<1.0, like the other repos. uv 0.13 warns about the old pin.Locally with ty 0.0.87,
just lint-ciis clean andjust test-cipasses (362 passed, 100% coverage).