Repository navigation
Conversation
This was referenced Oct 25, 2026
The crate, sdk-python and later the server read one copy of these messages. The gRPC service and its Nexus annotations come with the server.
moetemp
force-pushed
the
moe/brook/review/a1-stream-messages
branch
from
October 26, 2026 07:48
e96caa1 to
3fa37e2
Compare
moetemp
changed the title
moetemp
changed the title
Owner
Author
|
Opened upstream as temporalio#895, from the same commit ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
This PR adds the Stream service messages, marked experimental.
stream/v1/message.protohas the shared types,streamservice/v1/request_response.protohas the requests and responses, andenums/v1/stream.protohas the enums.StreamRef.owneris acommon.v1.Execution, the Workflow or Standalone Activity that owns the Stream.service.protoyet. It comes with the later stage of the project (Jetty).make ci-buildpasses.Part of the Brook review series.
Why?
The SDKs and Redis already use these messages, so they need one home before a server serves them.
Breaking changes
None. These are new files.
Server PR
None needed for now.