Skip to content

[Brook] Added the stream handles over Core and refused unsupported owners. - #241

Closed
moetemp wants to merge 16 commits into
moe/brook/v2/p2e-provider-pluginfrom
moe/brook/v2/p3c-unsupported-owners
Closed

moetemp wants to merge 16 commits into
moe/brook/v2/p2e-provider-pluginfrom
moe/brook/v2/p3c-unsupported-owners

Conversation

@moetemp

@moetemp moetemp commented Oct 16, 2026 •

Copy link
Copy Markdown
Owner

What changed?

This PR adds the Activity and client stream handles over Core, and refuses owners this release doesn't support. A producer hashes before the codec and moves its sequence only when an append succeeds. An Activity sends a typed ActivityProducer and Core derives the producer id. Reads follow the run chain across Continue-as-New. A Local Activity, workflow_reader() and any kind other than "workflow" raise StreamUnsupportedError where a handle opens.

Stacked on #240.

Why?

Core owns owner checks, cursors, dedupe and supersession, so a handle is a thin loop over the stub (DD-88). A ref that fails to decode would fail a Workflow Task on every retry, so the check runs at open and not at decode.

How did you test it?

Link to a test plan if any -

  • Unit Tests
  • Staging
  • End to End Tests

Ran the handle and owner tests on the dev server.

@moetemp

moetemp commented Oct 21, 2026

Copy link
Copy Markdown
Owner Author

Replaced by the Brook v3 stack, #322 to #338.

@moetemp moetemp closed this Oct 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant