Repository navigation
Conversation
The stream reference protos come from the crate's API copy, so a stored link has the same types here as in Jetty.
A producer links a child Workflow's stream with link and join, and follow() reads a stream and the streams it links in one order. Only Workflow-owned streams are link targets.
3 tasks
Lower stages pin crate commits from before batch_digests, and each stage must stay green on its own pin.
An agent writes an event and the link that goes with it in one append, so a resend dedupes them together.
moetemp
changed the title
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
This PR adds Link Records and the client Link Follower to Brook. A Workflow producer and a
StreamProducerwrite anOPENwithlink()and aJOINwithjoin().StreamHandle.follow()andActivityStreamHandle.follow()read a stream and the streams its links open in one order, withmax_depth=4andmax_open=16by default. Link reports come asOPENED,DONE,UNAVAILABLEandSKIPPEDitems, and the last item of each batch carries aFollowPosition. A link names a Workflow's stream only, and any other ref raisesValueError.appendalso takesStreamLinkitems next to plain values, so an event and its link land as one batch with one dedupe identity.The bridge pins sdk-streams
ss5(moetemp/sdk-streams#16). The protos and the bridge client are regenerated from it, andStreamReferencecomes from the crate's API copy, as in Jetty. The names and signatures match Jetty's, so the Jetty layers keep their code.Why?
An agent can link a child's stream in place of copying its records, and a client still gets one ordered view. The harness needs this to drop its client-side stream merge.
How did you test it?
Link to a test plan if any -