Repository navigation
Conversation
A reader of a Topic family, such as every sub-agent's Topic, had to list each Topic. subscribe(topic_prefixes=) also reads the Topics that start with a prefix. The crate pin moves to s7, which has the new ReadRecordsRequest field.
Owner
Author
|
Closing as stale. This layer is folded into the v5 tip, #365, and the upstream review uses a fresh series instead. Plan: https://www.notion.so/4048fc567738814990b7c796ac28fe3f |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
This PR adds
topic_prefixes=tosubscribe(). A Record passes when its Topic is intopics(exact match) or starts with one of the prefixes. With both empty, the read gives every Topic. The WIT copy has the newtopic-prefixesfield (proto field 10), the bindings are regenerated, and the crate pin moves to s71c8c01f5, which serves the field.Why?
A reader of a Topic family, such as every sub-agent's Topic, had to list each Topic (DECISIONS.md S29).
How did you test it?
pytest tests/contrib/streams, with a fake extension and a live Redis.test_vectors.pychecks that the vendored proto matches the crate's.