Repository navigation
Conversation
Owner
Author
|
Closing as stale. This layer is folded into the v5 tip, #365, and the upstream review uses a fresh series instead. Plan: https://www.notion.so/4048fc567738814990b7c796ac28fe3f |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
This PR pins the v4 crate, sdk-streams s14
62544055, and regenerates the Stream bindings from the synced WIT and protos.The vendored protos now equal the crate's:
StreamRef.backend = 4,CreateStreamRequest.auto_close = 5,DescribeStreamResponse.auto_close = 4, the reservedidle_timeout(9) andSTREAM_RECORD_KIND_IDLE(4), and the new extension callsFlushRunBufferandWriteRecords. The WIT copy takes the same fields, dropsidle-timeoutfrom the long poll, and has no@nexus.one-way(S78), soappend_recordsandclose_streamare awaited stubs that return the response.The current facade follows the pin: the Workflow stubs go through the same
_nowcall ascreate_stream, and the reads loseidle_timeoutand theIdleitem, since the crate no longer writes one (S75).A later commit moves the pin from s14
60bf1ceeto62544055, where every failed Workflow flush names the Stream and the Topic.Why?
The v4 API (decisions S62 to S79) needs these crate changes: reads without idle, auto-close, the backend name on a ref, the run-buffer flush before a Local Activity, and an awaited write for Activities and clients. The layers above build on this pin.
How did you test it?
pytest tests/contrib/streamson the memory Store and on a scratchredis-server, against the stock dev server.test_vectorsmatches the crate's protos at the new pin.pyright,mypy,basedpyright,ruffon the changed files.