Repository navigation
Conversation
Owner
Author
|
Closing as stale. This layer is folded into the v5 tip, #365, and the upstream review uses a fresh series instead. Plan: https://www.notion.so/4048fc567738814990b7c796ac28fe3f |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
This PR adds the live tests that the new API still lacked.
A client with two Stream plugins writes one Stream id on each backend, and each handle reads from its own. A Workflow write to a Stream that a client closed is dropped, since a live run and its replay must act the same. A Store error in the Workflow flush fails the Workflow Task with the Stream id in the message. An Activity refuses a Topic outside the definition. A continued run that fails once and retries keeps the chain's close-with-run Stream, and only the last run closes it.
Why?
The plan's last layer runs the live lane on the new API. These cases cover the backend name, S69's error text, and close-with-run across continue-as-new and retry.
How did you test it?
pytest tests/contrib/streamson the memory Store and on a scratchredis-server, against the stock dev server. At this layerpoe lintpasses, and the full suite passes excepttest_envconfig, which reads a Temporal config file on this host.