Repository navigation
Conversation
…ocs-and-dead-calls
…ocs-and-dead-calls
…ocs-and-dead-calls
…ocs-and-dead-calls
…ocs-and-dead-calls
…ocs-and-dead-calls
…ocs-and-dead-calls
Owner
Author
|
Closing as stale. This layer is folded into the v5 tip, #365, and the upstream review uses a fresh series instead. Plan: https://www.notion.so/4048fc567738814990b7c796ac28fe3f |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
This PR pins sdk-streams s15
daeb5fc2and syncs the WIT and proto copies with the crate.The WIT copy in
scripts/_witis now the crate'scrates/streams/nexus/stream-service.wit, whose@nexus.doclines fit 100 columns. The extension proto drops the buffered writer path:Publish,FlushWriter,batch_interval,max_buffered_recordsand thestream_buffer_fullreason. The bindings are regenerated, and only their docstrings change.On the Python side,
StreamBufferFullErrorgoes, since no call can raise it now. The test fake loses itsPublishandFlushWriterbranches. The facade already used onlyWriteRecordsandCloseWriter, andBatchOptionswas already gone.Why?
The awaited publish writes with one
WriteRecordscall, andBufferedPublisherbatches in Python, so the crate's interval flush has no user. The crate is the source of the WIT now, so each SDK copies one file.How did you test it?
pytest tests/contrib/streamson the memory Store and on a scratchredis-server, against the stock dev server.test_vectorsmatches the crate's protos at the new pin.poe lintpasses.