Repository navigation
Conversation
Owner
Author
|
Closing as stale. This layer is folded into the v5 tip, #365, and the upstream review uses a fresh series instead. Plan: https://www.notion.so/4048fc567738814990b7c796ac28fe3f |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
This PR builds the Stream handles on the
Streamresource that nexgen n8 generates from the crate's s16 WIT (S84).The crate pin moves to s16
88abba51(a WIT change only),scripts/_wit/stream-service.witis its copy, andNEX_GEN_REVISIONis n8de0c7edd. The regenerated bindings havesystem/_resources/stream.pywithStream(stream=...)and itsappend_records,close,read_recordsanddescribemethods.create_streamreturns aStream, andCreateStreamResponseis nowCreateStreamResult.WorkflowStreamnow makes its calls through the resource.publishcallsStream.append_records,closecallsStream.close, and the create uses the generatedcreate_stream. The facade keeps the parts that the resource can't give: typed Topics from the definition, the run's replay and closed-Stream rules, and close-with-run. Activity and client handles read the offset through the generated client'sdescribe_stream. They keep the crate's writer calls (OpenWriter,WriteRecords,CloseWriter), since those are not IDL operations, and the close, which encodes its failure with the codec. The public API, tests and examples are unchanged.Why?
S84: the Stream handle is a WIT resource, so its calls come from the IDL and stay the same in every SDK.
How did you test it?
pytest tests/contrib/streams, including the examples, on the memory Store and on a scratchredis-server, against the stock dev server. A regen with n8 at this layer gives the committed bindings.poe lintpasses.