Repository navigation
Conversation
Owner
Author
|
Closing as stale. This layer is folded into the v5 tip, #365, and the upstream review uses a fresh series instead. Plan: https://www.notion.so/4048fc567738814990b7c796ac28fe3f |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR writes Activity and client Records through the
Writerresource that nexgen generates from the crate'sstream-writer.wit(S87).What changed?
The crate pin moves to s17
ef17adf7, andNEX_GEN_REVISIONto n8204b566e.scripts/_wit/stream-writer.witis the crate's copy, andscripts/gen_stream_service.pygenerates a second package,temporalio.contrib.streams.writer_system, withStreamWriterClientandWriter. It is a separate package because its models import the contrib protos, and the facade imports it lazily for the same reason. The vendoredstream_service.prototakes the crate's API options, and its_pb2is regenerated.StreamWriteropens a generatedWriterand callswrite_recordsandcloseon it. The generated client runs each Record body through the user's converter and codec, so the facade no longer encodes bodies. The extension transport carriesOpenWriter,WriteRecordsandCloseWriter, and setsnamespaceonly on a request that has the field. The internalStreamBackendprotocol is down toserviceandwriters, and the Local Activity pre-flush calls the plugin's extension backend directly. p30 (#357, S108) removes that pre-flush, because Workflow writes become Local Activities there. The hand-builtopen_writer,write_recordsandclose_writercalls are gone.writer_systemgets the same lint excludes as the generatedsystempackage.The public API, tests and examples are unchanged.
Why?
S87: the writer calls are in the IDL, so Activity and client handles wrap two generated resources,
StreamandWriter, and less of the facade is hand-written.How did you test it?
pytest tests/contrib/streams, including the examples, on the memory Store and on a scratchredis-server, against the stock dev server.poe lintpasses.