Repository navigation
Conversation
Owner
Author
|
Closing as stale. This layer is folded into the v5 tip, #365, and the upstream review uses a fresh series instead. Plan: https://www.notion.so/4048fc567738814990b7c796ac28fe3f |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR names a Stream by a renamed definition, and removes the
name=option (S111).What changed?
streams.with_name(Events, "turn-3")returns a subclass ofEventswith the same Topics and only the Stream name changed.Eventsstays unchanged, andEvents.tokensis still a Topic of the renamed definition.workflow.create_stream,create_stream_nowait,stream_handleandStreamClient.workflow_streamno longer takename=. The definition's name is the Stream name. The clientid=ofcreateandget_handlestays.The examples and tests that passed
name=now pass a renamed definition.Why?
S111: a name passed beside the definition is a second way to say which Stream it is. A renamed definition is one value that a Workflow and a client share.
It is a module function and not
Events.with_name(...), because@streams.defncan't add a method that a type checker sees. The function returns the definition's own type, so Topic typing and handle types stay as they are.How did you test it?
New tests: a renamed definition gives another Stream id and a later run reattaches to it with
stream_handle(streams.with_name(...)), and the original definition keeps its name and Topics. The streams suite passes on the memory and Redis backends, including the examples, andpoe lintis green.🤖 Generated with Claude Code