Skip to content

[Brook S9] Added the Stream examples and the end-to-end Redis tests. - #379

Open
moetemp wants to merge 1 commit into
moe/brook/review/s8-activity-handlesfrom
moe/brook/review/s9-examples
Open

moetemp wants to merge 1 commit into
moe/brook/review/s8-activity-handlesfrom
moe/brook/review/s9-examples

Conversation

@moetemp

@moetemp moetemp commented Oct 25, 2026 •

Copy link
Copy Markdown
Owner

What was changed

This PR adds the Stream examples, the end-to-end Redis tests, the Streams module doc of temporalio.common, the Streams changelog fragment and a CODEOWNERS entry.

  • Each example follows the Python tab of its API proposal section, and runs as a test on both backends. A Workflow hands out its Stream through a stream query.
  • The end-to-end tests cover Workflow and Activity writes to one Stream, replays, codecs, eviction, retries, continue-as-new and two backends on one client.
  • worker_setup.py says that a Worker serves only one backend. Its test checks that a Worker on the migration's client with two backends raises StreamConfigError.
  • The changelog fragment covers the whole stack, so S1 to S8 have none.

Depends on S8 (#378).
Part of the Brook review series.

Why?

After this PR, moe/brook/review/feature-streams has the whole API. Upstream merges feature/streams into main once, so main never has half an API. The examples are the API docs until the docs site has Streams.

Open question. CODEOWNERS names the AI SDK team and the SDK team for the Streams paths. Which team owns them?

Checklist

  1. How was this tested:
    • poe lint, poe bridge-lint, poe gen-docs, the check-protos steps, and the Worker, client, Workflow, Nexus, converter, bridge and Streams suites. The Streams tests also ran with protobuf 3.20, as check-protos does.
    • Fork CI passes, except the arm jobs, since the fork has no arm runners. The Redis lane runs on Redis 7.0 (Ubuntu) and Redis 8 (macOS).

@moetemp
moetemp force-pushed the moe/brook/review/s9-examples branch from 55f7a0d to c4f1ffc Compare October 26, 2026 00:14
@moetemp
moetemp force-pushed the moe/brook/review/s8-activity-handles branch from 223a99b to fa0c9d3 Compare October 26, 2026 02:08
@moetemp
moetemp force-pushed the moe/brook/review/s9-examples branch from c4f1ffc to ca1e58d Compare October 26, 2026 02:08
@moetemp
moetemp force-pushed the moe/brook/review/s8-activity-handles branch from fa0c9d3 to 24f6a90 Compare October 26, 2026 04:13
@moetemp
moetemp force-pushed the moe/brook/review/s9-examples branch 2 times, most recently from 3029be1 to ed9287d Compare October 26, 2026 04:52
@moetemp
moetemp force-pushed the moe/brook/review/s8-activity-handles branch 2 times, most recently from 79cf55a to 15eebd7 Compare October 26, 2026 08:44
@moetemp
moetemp force-pushed the moe/brook/review/s9-examples branch 2 times, most recently from 0bb4d28 to ed58b77 Compare October 27, 2026 09:07
@moetemp
moetemp force-pushed the moe/brook/review/s8-activity-handles branch from 15eebd7 to b3da39a Compare October 27, 2026 09:07
@moetemp
moetemp force-pushed the moe/brook/review/s9-examples branch from ed58b77 to 3afa400 Compare October 27, 2026 09:17
@moetemp
moetemp force-pushed the moe/brook/review/s8-activity-handles branch from b3da39a to 212ef71 Compare October 27, 2026 09:17
@moetemp
moetemp force-pushed the moe/brook/review/s9-examples branch 2 times, most recently from 98dc9dc to e237cb7 Compare October 28, 2026 07:54
The examples run on the memory and Redis lanes, as the tests do. The
`temporalio.common` module doc and the changelog describe Streams.
@moetemp
moetemp force-pushed the moe/brook/review/s8-activity-handles branch from 0c7ec5b to 86d50a1 Compare October 28, 2026 08:05
@moetemp
moetemp force-pushed the moe/brook/review/s9-examples branch from e237cb7 to 0bf1696 Compare October 28, 2026 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant