Skip to content

PYTHON-6149 Add maxPoolSize=0 regression test and fix docstring - #3132

Closed
aclark4life wants to merge 7 commits into
mainfrom
PYTHON-6149-followup
Closed

aclark4life wants to merge 7 commits into
mainfrom
PYTHON-6149-followup

Conversation

@aclark4life

Copy link
Copy Markdown
Contributor

PYTHON-6149

Follow-up to #3099.

Changes in this PR

  • Add a regression test for maxPoolSize=0/None with minPoolSize=5 and for the still-raising maxPoolSize=10, minPoolSize=20 case.
  • Fix the max_pool_size docstring: "Cannot be 0" contradicted the pool behavior (maxPoolSize=0 has meant unlimited, asserted by test_max_pool_size_zero); it now says a value of 0 or None means no limit.

Test Plan

DB_IP=… DB_PORT=… pytest test/test_pooling.py -k max_pool_size: 7 passed with the fix; the new test fails against the old guard (max_pool_size is not None).

Checklist

Checklist for Author

  • Did you update the changelog (if necessary)?
  • Is the intention of the code captured in relevant tests?
  • If there are new TODOs, has a related JIRA ticket been created?

Checklist for Reviewer

  • Does the title of the PR reference a JIRA Ticket?
  • Do you fully understand the implementation? (Would you be comfortable explaining how this code works to someone else?)
  • Have you checked for spelling & grammar errors?
  • Is all relevant documentation (README or docstring) updated?

@aclark4life

Copy link
Copy Markdown
Contributor Author

Superseded: changes pushed directly to #3099
(patch-1).

@aclark4life
aclark4life deleted the PYTHON-6149-followup branch October 16, 2026 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants