Repository navigation
fix: move/rename of part file in masked dir/storage - #65506
Merged
Merged
Conversation
salmart-dev
added
3. to review
salmart-dev
marked this pull request as ready for review
October 14, 2026 15:03
salmart-dev
requested review from
icewind1991,
leftybournes,
provokateurin and
sorbaugh
and removed request for
a team
October 14, 2026 15:03
Contributor
Author
|
/backport to stable35 |
Contributor
Author
|
/backport to stable34 |
Contributor
Author
|
/backport to stable33 |
salmart-dev
force-pushed
the
fix/permission-masks-fixes
branch
from
October 20, 2026 09:38
ee6f39e to
7bee3d2
Compare
icewind1991
approved these changes
Oct 20, 2026
provokateurin
approved these changes
Oct 26, 2026
The new behaviour is needed when the partial files are not uploaded directly at the target directory, which is a configurable option (part_file_in_storage=false). Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: Salvatore Martire <4652631+salmart-dev@users.noreply.github.com> # Conflicts: # tests/lib/Files/Storage/Wrapper/DirPermissionsMaskTest.php # tests/lib/Files/Storage/Wrapper/PermissionsMaskTest.php
Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: Salvatore Martire <4652631+salmart-dev@users.noreply.github.com>
salmart-dev
force-pushed
the
fix/permission-masks-fixes
branch
from
October 26, 2026 13:10
7bee3d2 to
47d77ba
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves: #65505
Follow-up of #62986
.ocTransferId\d+.partfiles even if they are not uploaded in the same directory as the destination (as this may happen for several reasons)DirPermissionsMaskand new cases for the fixed problemsPermissionsMaskchecks forCREATEpermissions only when target does not existChecklist
3. to review, feature component)stable32)AI (if applicable)