Repository navigation
Show the commit in the footer after a manual deploy too - #6
Merged
Merged
Conversation
fdb
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Frederik · project thread
Before: after
npm run deploythe footer showed no version, because only the Workers Builds deploy passed the commit.After:
npm run deploypassesgit rev-parse HEADasGIT_COMMITtoo, so the footer links the deployed commit either way.How: the script only passes the hash when
git diff --quiet HEADsays the tree is clean, otherwisenone, so the footer never links a commit that differs from what runs. A barenpx wrangler deploystill shows no version; DEPLOY.md says so.