Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/quiet-use-client-warnings.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@doc-kit/generator-react': patch
---

Stop the Vite builds from warning about every `"use client"` directive in dependencies
24 changes: 24 additions & 0 deletions packages/react/src/html/bundlers/__tests__/vite.test.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,30 @@ describe('Vite configuration', () => {
assert.strictEqual(config.build.manifest, 'manifest.json');
});

it("leaves out module-level directive warnings unless they're asked for", () => {
/**
* @param {import('vite').UserConfig} [vite]
*/
const checksFor = vite =>
createViteConfig({
sources: new Map(),
input: {},
server: false,
outDir: output,
config: getConfig('html'),
vite,
}).build.rolldownOptions.checks;

assert.deepStrictEqual(checksFor(), { moduleLevelDirective: false });

const checks = { moduleLevelDirective: true, eval: false };

assert.deepStrictEqual(
checksFor({ build: { rolldownOptions: { checks } } }),
checks
);
});

it('keeps the server library self-contained', () => {
const vite = {
ssr: {
Expand Down
9 changes: 9 additions & 0 deletions packages/react/src/html/bundlers/vite.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -230,6 +230,15 @@ export const createViteConfig = ({
...vite.build?.rolldownOptions,
input,
...(server ? { external: [] } : {}),

// Dependencies' `"use client"` directives are for React Server
// Components, which bundling drops and this site doesn't use. See
// https://rolldown.rs/in-depth/directives#other-directives
checks: {
moduleLevelDirective: false,
...vite.build?.rolldownOptions?.checks,
},

output: {
...vite.build?.rolldownOptions?.output,
format: 'es',
Expand Down
Loading