Repository navigation
meta: define package identity - #166
Merged
Merged
Conversation
Signed-off-by: Daniel Cavalcante <dcavalcante@gmail.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
👋 Codeowner Review RequestThe following codeowners have been identified for the changed files: Team reviewers: @nodejs/nodejs-website Please review the changes when you have a chance. Thank you! 🙏 |
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The manifest and lockfile changes are consistent, valid, and fulfill the stated purpose.
Review effort: Balanced
Findings: None
What changed in this PR
Defines a stable npm package identity and prevents accidental publication.
Changes:
- Adds
"name": "learn"and"private": true. - Synchronizes the lockfile’s root package metadata.
| File | Description |
|---|---|
package.json |
Defines package identity and marks it private. |
package-lock.json |
Records the root package name. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
bjohansebas
approved these changes
Oct 5, 2026
AugustinMauroy
approved these changes
Oct 5, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
package-lock.jsonhas the root package identified aslearn, butpackage.jsondid not define a package name.Without an explicit
name, npm can derive it from the checkout directory, which can cause the lockfile name to change depending on where the repository is cloned.This adds:
"name": "learn"to make the existing package identity explicit and stable."private": truebecause this repository is not intended to be published to npm.Follow-up to #164.