Repository navigation
Conversation
The mappings parser detects a segment that has only a generated column by peeking at the next character. At the end of the mappings string the peek returns an empty string, which is not a separator, so a final generated-only segment is decoded with phantom zero deltas and inherits the source, line, and column of the segment before it. With --enable-source-maps, stack frames in code after the last mapped segment are then attributed to the last mapped source. Check for the end of the string before reading source fields. Signed-off-by: Jacky Zhao <j.zhao2k19@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #66264 +/- ##
==========================================
+ Coverage 90.30% 90.43% +0.12%
==========================================
Files 789 791 +2
Lines 272880 276595 +3715
Branches 52110 53119 +1009
==========================================
+ Hits 246418 250125 +3707
+ Misses 16912 16864 -48
- Partials 9550 9606 +56
🚀 New features to boost your workflow:
|
legendecas
reviewed
Oct 8, 2026
Member
There was a problem hiding this comment.
Would you mind adding the hasNext check here as well? This could be verified with a test like:
{
const sm = new SourceMap({
version: 3,
sources: ['a.js'],
names: ['should-not-be-used'],
mappings: 'AAAA', // No name field.
});
assert.deepStrictEqual(sm.findEntry(0, 0), {
generatedLine: 0,
generatedColumn: 0,
originalSource: 'a.js',
originalLine: 0,
originalColumn: 0,
name: undefined, // No name field.
});
}Check hasNext() before reading the optional name field, and add a test for a segment that has no name. Signed-off-by: Jacky Zhao <j.zhao2k19@gmail.com> Assisted-by: Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The mappings parser detects a segment that has only a generated column by peeking at the next character.
At the end of the mappings string the peek returns an empty string, which is not a separator, so a final generated-only segment is decoded with phantom zero deltas and inherits the source, line, and column of the segment before it.
With --enable-source-maps, stack frames in code after the last mapped segment are then attributed to the last mapped source.
repro.js:repro.js.map:$ node --enable-source-maps repro.js Error: boom at vendor (app.ts:1:1)With this change:
$ node --enable-source-maps repro.js Error: boom at vendor (repro.js:2:27)What Changed
Check for the end of the string before reading source fields.
Disclaimer: this PR was written with the help of Opus 5.5 but I have personally read, reviewed, and validated the changes.