Skip to content

vfs: unflag - #66318

Open
mcollina wants to merge 2 commits into
nodejs:mainfrom
mcollina:unflag-node-vfs
Open

vfs: unflag#66318
mcollina wants to merge 2 commits into
nodejs:mainfrom
mcollina:unflag-node-vfs

Conversation

@mcollina

@mcollina mcollina commented Sep 26, 2026

Copy link
Copy Markdown
Member

No description provided.

@nodejs-github-bot

nodejs-github-bot commented Sep 26, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/config
  • @nodejs/ffi
  • @nodejs/security-wg
  • @nodejs/startup

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs involving general changes in the lib/ or src/ directories. needs-ci PRs that need a full CI run. labels Sep 26, 2026
@mcollina
vfs: unflag
26a1dc8 
Signed-off-by: Matteo Collina <hello@matteocollina.com>
Renegade334
Renegade334 reviewed Sep 26, 2026
View reviewed changes
Comment thread lib/internal/process/pre_execution.js
@mcollina
mcollina marked this pull request as ready for review September 29, 2026 14:21
@mcollina mcollina added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 29, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 29, 2026
@nodejs-github-bot

nodejs-github-bot commented Sep 29, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/78075/

@mcollina
vfs: keep --experimental-vfs negatable
99c479f 
Keep VFS enabled by default while allowing the negated flag to disable
node:vfs exposure and --vfs-load.

Assisted-by: pi
Signed-off-by: Matteo Collina <hello@matteocollina.com>
@codecov

codecov Bot commented Sep 29, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.37%. Comparing base (95279e7) to head (99c479f).
⚠️ Report is 278 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #66318      +/-   ##
==========================================
- Coverage   92.78%   90.37%   -2.41%     
==========================================
  Files         422      792     +370     
  Lines      192238   275502   +83264     
  Branches    29636    52803   +23167     
==========================================
+ Hits       178367   248996   +70629     
- Misses      13548    16924    +3376     
- Partials      323     9582    +9259
Files with missing lines Coverage Δ
lib/internal/vfs/file_system.js 99.63% <100.00%> (-0.01%) ⬇️
lib/vfs.js 100.00% <100.00%> (ø)
src/node.cc 79.24% <100.00%> (ø)
src/node_options.cc 81.59% <ø> (ø)
src/node_options.h 95.67% <100.00%> (ø)

... and 514 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ljharb

ljharb commented Sep 30, 2026

Copy link
Copy Markdown
Member

Before unflagging, since we now own npmjs.com/vfs, can we allow 'vfs' as a specifier to import/require this code module?

@mcollina mcollina added the resume-ci Add this label to resume the latest eligible Jenkins CI run on a PR with an approving review. label Oct 6, 2026
@github-actions github-actions Bot added resume-ci-failed Resuming CI with the resume-ci label failed and requires manual intervention. and removed resume-ci Add this label to resume the latest eligible Jenkins CI run on a PR with an approving review. labels Oct 10, 2026
@github-actions

github-actions Bot commented Oct 10, 2026

Copy link
Copy Markdown
Contributor

Failed to resume CI

✖ Refusing to resume CI job 78075: its approved commit does not match the current PR HEAD

Full Auto Start CI output 
�[36m⠋�[39m Validating Jenkins credentials
�[36m⠋�[39m Validating Jenkins credentials
✔  Jenkins credentials valid
�[36m⠙�[39m Looking for CI runs for pull request 66318
�[36m⠙�[39m Looking for CI runs for pull request 66318
�[36m⠙�[39m Getting PR from nodejs/node/pull/66318
�[36m⠙�[39m Getting reviews from nodejs/node/pull/66318
�[36m⠙�[39m Getting comments from nodejs/node/pull/66318
✔  Found PR CI job 78075
�[36m⠹�[39m Querying data for job/node-test-pull-request/78075/
�[36m⠹�[39m Querying data for job/node-test-pull-request/78075/
�[36m⠹�[39m Querying API for job/node-test-pull-request/78075/
✔  Build data downloaded
�[36m⠹�[39m Checking whether PR CI job 78075 can be resumed
�[36m⠹�[39m Checking whether PR CI job 78075 can be resumed
✔  Jenkins offers a Resume build action
�[36m⠹�[39m Checking failures against changed PR files
�[36m⠹�[39m Checking failures against changed PR files
�[36m⠸�[39m Querying data for job/node-test-pull-request/78075/
�[36m⠸�[39m Querying API for job/node-test-pull-request/78075/
✔  Build data downloaded
�[36m⠸�[39m Querying failures of job/node-test-commit/92887/
�[36m⠸�[39m Querying failures of job/node-test-commit/92887/
�[36m⠸�[39m Querying API for job/node-test-commit-linux/73647/
�[36m⠸�[39m Querying API for job/node-test-commit-smartos/68829/
�[36m⠸�[39m Querying API for job/node-test-commit-linux-containered/59583/
�[36m⠸�[39m Querying console text for job/node-test-commit-custom-suites-freestyle/50355/
�[36m⠼�[39m Querying API for job/node-test-commit-linux/nodes=fedora-last-latest-x64/73647/
�[36m⠼�[39m Querying API for job/node-test-commit-linux/nodes=fedora-latest-x64/73647/
�[36m⠼�[39m Querying API for job/node-test-commit-linux-containered/nodes=ubuntu2404_sharedlibs_icu_x64/59583/
�[36m⠼�[39m Querying API for job/node-test-commit-linux-containered/nodes=ubuntu2404_sharedlibs_openssl111_x64/59583/
�[36m⠼�[39m Querying API for job/node-test-commit-linux-containered/nodes=ubuntu2404_sharedlibs_openssl30_x64/59583/
�[36m⠼�[39m Querying API for job/node-test-commit-linux-containered/nodes=ubuntu2404_sharedlibs_openssl35_x64/59583/
�[36m⠼�[39m Querying API for job/node-test-commit-linux-containered/nodes=ubuntu2404_sharedlibs_openssl40_x64/59583/
�[36m⠼�[39m Querying API for job/node-test-commit-linux-containered/nodes=ubuntu2404_sharedlibs_shared_x64/59583/
�[36m⠼�[39m Querying API for job/node-test-commit-linux-containered/nodes=ubuntu2404_sharedlibs_smallicu_x64/59583/
�[36m⠼�[39m Querying API for job/node-test-commit-linux-containered/nodes=ubuntu2404_sharedlibs_withoutintl_x64/59583/
�[36m⠼�[39m Querying API for job/node-test-commit-linux-containered/nodes=ubuntu2404_sharedlibs_withoutssl_x64/59583/
�[36m⠼�[39m Querying API for job/node-test-commit-linux-containered/nodes=ubuntu2404_sharedlibs_zlib_x64/59583/
�[36m⠴�[39m Querying API for job/node-test-commit-smartos/nodes=smartos23-x64/68829/
�[36m⠴�[39m Querying console text for job/node-test-commit-linux/nodes=fedora-last-latest-x64/73647/
�[36m⠴�[39m Querying console text for job/node-test-commit-linux/nodes=fedora-latest-x64/73647/
�[36m⠴�[39m Querying console text for job/node-test-commit-smartos/nodes=smartos23-x64/68829/
�[36m⠦�[39m Querying console text for job/node-test-commit-linux-containered/nodes=ubuntu2404_sharedlibs_icu_x64/59583/
�[36m⠦�[39m Querying console text for job/node-test-commit-linux-containered/nodes=ubuntu2404_sharedlibs_openssl111_x64/59583/
�[36m⠦�[39m Querying console text for job/node-test-commit-linux-containered/nodes=ubuntu2404_sharedlibs_openssl30_x64/59583/
�[36m⠦�[39m Querying console text for job/node-test-commit-linux-containered/nodes=ubuntu2404_sharedlibs_openssl35_x64/59583/
�[36m⠦�[39m Querying console text for job/node-test-commit-linux-containered/nodes=ubuntu2404_sharedlibs_openssl40_x64/59583/
�[36m⠦�[39m Querying console text for job/node-test-commit-linux-containered/nodes=ubuntu2404_sharedlibs_shared_x64/59583/
�[36m⠦�[39m Querying console text for job/node-test-commit-linux-containered/nodes=ubuntu2404_sharedlibs_smallicu_x64/59583/
�[36m⠦�[39m Querying console text for job/node-test-commit-linux-containered/nodes=ubuntu2404_sharedlibs_withoutintl_x64/59583/
�[36m⠦�[39m Querying console text for job/node-test-commit-linux-containered/nodes=ubuntu2404_sharedlibs_withoutssl_x64/59583/
�[36m⠦�[39m Querying console text for job/node-test-commit-linux-containered/nodes=ubuntu2404_sharedlibs_zlib_x64/59583/
✔  Data downloaded
✔  No changed PR files found in available failure details
   ✖  Refusing to resume CI job 78075: its approved commit does not match the current PR HEAD

View workflow run

@mcollina mcollina added request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. request-ci-failed Starting CI with the request-ci label failed and requires manual intervention. and removed request-ci-failed Starting CI with the request-ci label failed and requires manual intervention. resume-ci-failed Resuming CI with the resume-ci label failed and requires manual intervention. labels Oct 10, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 10, 2026
@nodejs-github-bot

nodejs-github-bot commented Oct 10, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/78294/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Renegade334 Renegade334 Renegade334 left review comments
@ShogunPanda ShogunPanda ShogunPanda approved these changes
@jasnell jasnell jasnell approved these changes

Assignees

No one assigned

Labels

lib / src Issues and PRs involving general changes in the lib/ or src/ directories. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@mcollina @nodejs-github-bot @ljharb @ShogunPanda @jasnell @Renegade334