test_runner: rerun failing todo tests in suites

[barakor]

A failing todo subtest does not fail its parent, so the parent suite was recorded as passed in the rerun state file along with its children. On the next run the suite was replayed synthetically and the failing todo subtest was marked as passed instead of being rerun.

Do not record a passed test whose descendant failed, so the suite body runs again while passing siblings are still replayed from their own entries. Document that a failing todo test counts as not yet passed.

[nodejs-github-bot]

Review requested:

• @nodejs/test_runner

[github-actions]

Welcome to Node.js, and thank you for your first contribution!

Before review, please take a moment to read:

• the guide for first-time contributors
• the contribution and automation policies
• the pull request guide
• the AI use policy
• the Code of Conduct

Please make sure every commit is signed off. For a first pull request, GitHub Actions require collaborator approval and Jenkins CI must be started by a collaborator or triager, so an initial wait is normal.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/78256/

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.44%. Comparing base (f9defa6) to head (5be39f9).
⚠️ Report is 9 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #66605   +/-   ##
=======================================
  Coverage   90.43%   90.44%           
=======================================
  Files         791      791           
  Lines      276563   276573   +10     
  Branches    53115    53121    +6     
=======================================
+ Hits       250117   250135   +18     
- Misses      16850    16851    +1     
+ Partials     9596     9587    -9     

Files with missing lines	Coverage Δ
lib/internal/test_runner/reporter/rerun.js	93.40% <100.00%> (+0.81%)	⬆️

... and 29 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/78261/

[aduh95]

@MikeMcC399 can you please refrain from cancelling top-level jobs? Not only the cancellation does not propagate to the lower jobs (the ones that are actually stuck), but it also removes the possibility to resume the CI.

[MikeMcC399]

@aduh95

can you please refrain from cancelling top-level jobs? Not only the cancellation does not propagate to the lower jobs (the ones that are actually stuck), but it also removes the possibility to resume the CI.

This was related to the issue discussed in https://openjs-foundation.slack.com/archives/C03BJP63CH0/p1791541446396999 and the open nodejs/build#4511 issue.

I may have taken the wrong step in this issue, however the re-run I started was successful. Sorry, if I caused you a problem and if I chose the wrong corrective action. In hindsight for this issue, I should probably just have waited a few more hours before doing anything.

[nodejs-github-bot]

Landed in 38a5f10