Skip to content

[v24.x backport] buffer: fix unaligned UTF-16LE decoding - #66625

Open
mcollina wants to merge 1 commit into
nodejs:v24.x-stagingfrom
mcollina:backport-65905-to-v24.x
Open

mcollina wants to merge 1 commit into
nodejs:v24.x-stagingfrom
mcollina:backport-65905-to-v24.x

Conversation

@mcollina

@mcollina mcollina commented Oct 9, 2026 •

Copy link
Copy Markdown
Member

@mcollina
mcollina requested a review from a team as a code owner October 9, 2026 06:38
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/actions
  • @nodejs/devcontainer
  • @nodejs/tsc

@nodejs-github-bot nodejs-github-bot added meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory. labels Oct 9, 2026
@mcollina
mcollina changed the base branch from main to v24.x-staging October 9, 2026 06:39
@codecov

codecov Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.29%. Comparing base (9e39360) to head (e939bf1).
⚠️ Report is 588 commits behind head on v24.x-staging.

Additional details and impacted files
@@                Coverage Diff                @@
##           v24.x-staging   #66625      +/-   ##
=================================================
- Coverage          90.31%   90.29%   -0.02%     
=================================================
  Files                711      718       +7     
  Lines             228425   238001    +9576     
  Branches           43160    45248    +2088     
=================================================
+ Hits              206293   214907    +8614     
- Misses             14090    14613     +523     
- Partials            8042     8481     +439     
Files with missing lines Coverage Δ
src/string_bytes.cc 73.01% <100.00%> (+2.40%) ⬆️

... and 260 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aduh95 aduh95 added the v24.x Issues that can be reproduced on v24.x or PRs targeting the v24.x-staging branch. label Oct 9, 2026
@mcollina mcollina changed the title Backport 65905 to v24.x [v24.x backport] buffer: fix unaligned UTF-16LE decoding Oct 9, 2026
For odd-length input, the destination only has room for complete code
units. Copy those units and ignore the trailing byte. This matches the
aligned and big-endian paths.

Backport of nodejs#65905 (commit
b805fb5) to the v24.x release line.

Assisted-by: pi
Signed-off-by: Matteo Collina <hello@matteocollina.com>
@mcollina
mcollina force-pushed the backport-65905-to-v24.x branch from 375dd91 to e939bf1 Compare October 9, 2026 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory. v24.x Issues that can be reproduced on v24.x or PRs targeting the v24.x-staging branch.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants