Skip to content

build: do not include shared gtest in node link path - #66626

Open
aduh95 wants to merge 1 commit into
nodejs:mainfrom
aduh95:gtest-test-only
Open

aduh95 wants to merge 1 commit into
nodejs:mainfrom
aduh95:gtest-test-only

Conversation

@aduh95

@aduh95 aduh95 commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

gtest symbols are only used by cctest, but atm ./configure --shared-gtest results in -lgtest being added for all compilation, which results in readelf -d bin/node listing NEEDED libgtest.so. This PR introduces a separate node_shared_gtest_libraries list that is only provided to cctest recipe

Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/gyp

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to Node.js builds or CI infrastructure. needs-ci PRs that need a full CI run. labels Oct 9, 2026
@aduh95

aduh95 commented Oct 9, 2026

Copy link
Copy Markdown
Contributor Author

@nodejs/quic looks like we're broken on main, likely due to the V8 upgrade:

../src/quic/application.cc:159:12: error: no member named 'SetPrototypeV2' in 'v8::Object'; did you mean 'SetPrototype'?
  159 |   if (obj->SetPrototypeV2(env->context(), Null(env->isolate())).IsNothing()) {
      |            ^~~~~~~~~~~~~~
      |            SetPrototype
../deps/v8/include/v8-object.h:484:37: note: 'SetPrototype' declared here
  484 |   V8_WARN_UNUSED_RESULT Maybe<bool> SetPrototype(Local<Context> context,
      |                                     ^
1 error generated.
make[2]: *** [node_base.target.mk:605: /home/runner/work/node/node/node/out/Release/obj.target/node_base/src/quic/application.o] Error 1
make[2]: *** Waiting for unfinished jobs....

@pimterry

pimterry commented Oct 9, 2026

Copy link
Copy Markdown
Member

Yep, there's a pending fix in #66603

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Issues and PRs related to Node.js builds or CI infrastructure. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants