Repository navigation
Conversation
Collaborator
|
Review requested:
|
Signed-off-by: Efe Karasakal <hi@efe.dev>
Signed-off-by: Efe Karasakal <hi@efe.dev>
efekrskl
force-pushed
the
quic/truncate-close-reason
branch
from
October 10, 2026 12:38
8f2fdd1 to
63c637c
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #66644 +/- ##
==========================================
+ Coverage 90.43% 90.44% +0.01%
==========================================
Files 791 791
Lines 276593 276816 +223
Branches 53112 53195 +83
==========================================
+ Hits 250126 250375 +249
+ Misses 16867 16837 -30
- Partials 9600 9604 +4 🚀 New features to boost your workflow:
|
Contributor
|
https://github.com/nodejs/node/actions/runs/38052685564/job/114214912806 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Long reason strings inside a
CONNECTION_CLOSEframe could exceed the space available and crash the process.This PR limits the reason string to 256 UTF-8 bytes. Any string longer than the limit will get truncated. Also adds new tests and updates the documentation.
I think 256 bytes is a sensible default because the default maximum UDP datagram payload size is 1200 bytes. Before the handshake ngtcp2 can coalesce packets, encoding the same reason with 768 (3x256) bytes at most, this should leave enough headroom. This also matches Google QUICHE's limit