Repository navigation
Conversation
Collaborator
|
Review requested:
|
Signed-off-by: Efe Karasakal <hi@efe.dev>
efekrskl
force-pushed
the
quic/remove-setOutbound
branch
from
October 10, 2026 17:29
9d5a2b6 to
2c6c2d5
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #66646 +/- ##
==========================================
- Coverage 90.45% 90.45% -0.01%
==========================================
Files 791 791
Lines 276816 276797 -19
Branches 53197 53187 -10
==========================================
- Hits 250403 250373 -30
- Misses 16822 16834 +12
+ Partials 9591 9590 -1
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
QuicStream.setOutbound() is an undocumented, untested predecessor to
setBody(). It's not used anywhere in the codebase, and bypasses the enforced mutual exclusion withstream.writer.