Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
MattIPv4
changed the title
There was a problem hiding this comment.
🟢 Approval recommended
The terminology changes are consistent, complete, and follow the repository’s localization workflow.
0 open findings
What changed in this PR
Updates installation-method terminology from “official/unofficial” to “recommended/community.”
Changes:
- Renames translation keys and dropdown grouping.
- Revises installation-method criteria and explanatory copy.
- Corrects
grouppedMethodsspelling.
| File | Description |
|---|---|
packages/i18n/src/locales/en.json |
Updates English category labels. |
apps/site/pages/en/about/previous-releases.mdx |
Revises category guidance and criteria. |
apps/site/components/Downloads/Release/InstallationMethodDropdown.tsx |
Uses renamed category keys and variable. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9210 +/- ##
==========================================
- Coverage 86.07% 86.00% -0.07%
==========================================
Files 86 86
Lines 6060 6060
Branches 359 360 +1
==========================================
- Hits 5216 5212 -4
- Misses 840 844 +4
Partials 4 4 ☔ View full report in Codecov by Harness. |
|
Note Your Pull Request seems to be updating Translations of the Node.js Website. Whilst we appreciate your intent; Any Translation update should be done through our Crowdin Project. Thank you! |
📦 Build Size ComparisonSummary
Changes🔄 Modified Routes (4)
|
|
"Official" to me is the same as "recommended" but with a stronger endorsement, and does not imply a connection to the project. What is motivating this change? |
| --- | ||
| --- |
We already primarily use the "recommended"/"community" language, with the "official"/"unofficial" as secondary language. "Official" is a term that can be misunderstood, and while some may read it merely as a strong endorsement, others may read it as being part of the Node.js project itself. Removing it removes that ambiguity. I raised this on Slack last night, and the message received a significant number of ➕ reactions indicating support for the change. I would maybe reframe what you're asking by instead asking: what would motivate explicitly keeping the ambiguous "official"/"unofficial" language, rather than sticking with the clearer "recommended"/"community" language? |
|
|
|
Since "recommended" projects are also community projects, i think this increases confusion. What about "Officially Recommended" versus "Alternatives"? |
I still want to avoid "official" in any capacity, for the sake of avoiding a word that is evidently ambiguous to folks. However, I'm open to adopting "Alternatives" instead of "Community", or perhaps equally "Others", if there is consensus that is clearer (I can understand the confusion you highlighted). |
Description
This updates the wording used for the different categories of installation methods listed on the Downloads page, removing the "official"/"unofficial" wording that was used before, as this implies a status/connection to the Node.js project that these methods do not have.
Instead, we'll use the "recommended"/"community" categories that we were already using in part, and I've also updated the wording on the previous release page to reflect this, while also giving the Node.js project more leeway in the wording to have an opinion/act on lazy-consensus for which installation methods should be added, rather than implying that every method meeting the criteria for a category has to be added.
This PR also introduces one new criterion for the "recommended" methods, coming out of the discussion on Slack, that the methods allow for multiple Node.js versions to be installed concurrently, rather than being a single-version system-wide install.
Translations
I've included updated translations here, as it was just a case of removing the "official"/"unofficial" in the parentheses for all of them. Does this cause a problem? Can we sync those updated translations/keys to Crowdin? Looking at the UI, it seems I can go through and edit the key names + content for each language, to save these from becoming new untranslated keys.
For the translated versions of the previous releases page, should we remove those from the source to allow them to be translated again, so that the "official"/"unofficial" language doesn't remain? Will the Crowdin sync then automatically mark them in the UI as needing to be translated again?
Validation
All references to "official"/"unofficial" installation methods are removed; they are consistently referred to as "recommended"/"community".
Language used on the previous releases page makes the minimum criteria for the two categories clear, while leaving room for decisions to be made beyond the criteria.
Related Issues
N/A
Check List
pnpm formatto ensure the code follows the style guide.pnpm testto check if all tests are passing.pnpm buildto check if the website builds without errors.