Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
🟡 Changes recommended
The PR would close #8638 without addressing its primary request to hide incompatible dropdown options.
1 open finding
What changed in this PR
Enables nvm as an installation method for AIX.
Changes:
- Adds AIX to nvm’s supported operating systems.
| File | Description |
|---|---|
apps/site/util/download/constants.json |
Enables nvm selection for AIX. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9211 +/- ##
==========================================
- Coverage 86.07% 86.00% -0.07%
==========================================
Files 86 86
Lines 6060 6060
Branches 359 360 +1
==========================================
- Hits 5216 5212 -4
- Misses 840 844 +4
Partials 4 4 ☔ View full report in Codecov by Harness. |
richardlau
left a comment
There was a problem hiding this comment.
LGTM. Meets IBM's suggestion for AIX from #8638 (comment). Thank you.
📦 Build Size ComparisonSummary
Changes🔄 Modified Routes (4)
|

Description
When selecting AIX on the site, no installation methods are available currently. It was confirmed that nvm works on AIX, so let's enable that.
Validation
Select AIX on the downloads page, observe nvm selectable.
Related Issues
Fixes #8638
Check List
pnpm formatto ensure the code follows the style guide.pnpm testto check if all tests are passing.pnpm buildto check if the website builds without errors.