Skip to content

feat: mark nvm as an installation method for AIX - #9211

Open
MattIPv4 wants to merge 1 commit into
mainfrom
MattIPv4/recommend-nvm-aix
Open

MattIPv4 wants to merge 1 commit into
mainfrom
MattIPv4/recommend-nvm-aix

Conversation

@MattIPv4

@MattIPv4 MattIPv4 commented Oct 9, 2026

Copy link
Copy Markdown
Member

Description

When selecting AIX on the site, no installation methods are available currently. It was confirmed that nvm works on AIX, so let's enable that.

Validation

Select AIX on the downloads page, observe nvm selectable.

Related Issues

Fixes #8638

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run pnpm format to ensure the code follows the style guide.
  • I have run pnpm test to check if all tests are passing.
  • I have run pnpm build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

@MattIPv4
MattIPv4 requested a review from a team as a code owner October 9, 2026 16:37
Copilot AI balanced review requested due to automatic review settings October 9, 2026 16:37
@vercel

vercel Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
nodejs-org Ready Ready Preview Oct 9, 2026 4:37pm UTC

Request Review

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The PR would close #8638 without addressing its primary request to hide incompatible dropdown options.

1 open finding
What changed in this PR

Enables nvm as an installation method for AIX.

Changes:

  • Adds AIX to nvm’s supported operating systems.
File Description
apps/​site/​util/​download/​constants.json Enables nvm selection for AIX.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread apps/site/util/download/constants.json
@codecov

codecov Bot commented Oct 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.00%. Comparing base (bbbdde7) to head (d8b63a4).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9211      +/-   ##
==========================================
- Coverage   86.07%   86.00%   -0.07%     
==========================================
  Files          86       86              
  Lines        6060     6060              
  Branches      359      360       +1     
==========================================
- Hits         5216     5212       -4     
- Misses        840      844       +4     
  Partials        4        4              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@richardlau richardlau left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Meets IBM's suggestion for AIX from #8638 (comment). Thank you.

@github-actions

github-actions Bot commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

📦 Build Size Comparison

Summary

Metric Value
Old Total First Load JS 7.15 MB
New Total First Load JS 7.15 MB
Delta 24.00 B (0.00%)

Changes

🔄 Modified Routes (4)
Route Old First Load JS New First Load JS Delta
/[locale] 1.68 MB 1.68 MB 📈 6.00 B (0.00%)
/[locale]/[...path] 1.68 MB 1.68 MB 📈 6.00 B (0.00%)
/[locale]/blog/[...path] 1.68 MB 1.68 MB 📈 6.00 B (0.00%)
/[locale]/download/archive/[version] 1.68 MB 1.68 MB 📈 6.00 B (0.00%)

This branch was successfully deployed

1 active deployment
Preview — d8b63a4a Deployed Oct 9, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove irrelevant dropdown options for installing Node.js rather than disabling them

8 participants