Repository navigation
Document three-argument ConvertTimeBySystemTimeZoneId translation - #471
Merged
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: dab05258-0495-467d-920c-8b811a77bdf8
There was a problem hiding this comment.
🟢 Approval recommended
The documentation accurately reflects the linked provider implementation and its constraints.
0 open findings
What changed in this PR
Documents the EFCore.PG 11.0 translation for the three-argument time-zone conversion overload.
Changes:
- Adds the generated PostgreSQL expression.
- Documents input, result-kind, and
DateTimeOffsetlimitations.
| File | Description |
|---|---|
conceptual/EFCore.PG/mapping/translations.md |
Adds the new translation-table entry. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add one row to the existing date/time translation table for
TimeZoneInfo.ConvertTimeBySystemTimeZoneId(dateTime, sourceTimeZoneId, destinationTimeZoneId), introduced in EFCore.PG 11.0.Document
(dateTime AT TIME ZONE sourceTimeZoneId) AT TIME ZONE destinationTimeZoneId, the requiredtimestamp without time zoneinput, thetimestamp without time zone/DateTimeKind.Unspecifiedresult even for UTC destinations, and the unsupportedDateTimeOffsetoverload. Leave the existing two-argument overload unchanged.Provider implementation: npgsql/efcore.pg#3939.