Repository navigation
Remove row value regression test's global mapper dependency - #3959
Merged
Merged
Conversation
Keep record-to-tuple mapping local to the regression test so it does not depend on global mapper initialization order. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: d9e678d6-bbc7-403a-926d-dda2b087f5a7
There was a problem hiding this comment.
🟢 Approval recommended
The focused test-only change removes the global configuration dependency without altering regression coverage.
0 open findings
What changed in this PR
Makes the row-value regression test independent of shared data-source initialization order, preserving coverage for #3933 without changing product code.
Changes:
- Removes global record-to-tuple mapping configuration.
- Enables record-to-tuple mapping on the test’s data source.
| File | Description |
|---|---|
test/EFCore.PG.FunctionalTests/Query/AdHocQueryFiltersQueryNpgsqlTest.cs |
Localizes tuple mapping configuration while preserving regression assertions. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #3953, related to #3933.
Configure record-to-tuple mapping on the data source used by
Row_value_projection_over_filtered_navigation, instead of updatingNpgsqlConnection.GlobalTypeMapperafter a shared data source may already have been initialized. This keeps the configuration local to the regression test and removes its test-order dependency.The isolated
AdHocQueryFiltersQueryNpgsqlTestclass in Release on PostgreSQL 18.4 reproduced both sync/async failures before the change (29 passed, 2 failed) and passes all 31 tests after the change. No product code changes.