Skip to content

random-list: fix dice and the error helper on current nushell #1301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fdncred merged 2 commits into from
Oct 24, 2026
Merged

random-list: fix dice and the error helper on current nushell #1301

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
84629e8
random-list: import random dice from std and fix the error helper
qodelicious Oct 22, 2026
f2523f1
random-list: reject 0 dice and sides, return nothing for a 0 count
qodelicious Oct 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 28 additions & 27 deletions modules/random-list/random-list.nu
View file
Open in desktop
Comment thread
fdncred marked this conversation as resolved.
Original file line number Diff line number Diff line change
@@ -1,14 +1,15 @@
use std/random
Comment thread
fdncred marked this conversation as resolved.

def throw-error [
error: string
msg: string
span: record
] {
error make {
msg: $"(ansi red_bold)($error)(ansi reset)"
msg: $error
label: {
text: $msg
start: $span.start
end: $span.end
span: $span
Comment thread
fdncred marked this conversation as resolved.
}
}
}
Expand All @@ -21,11 +22,11 @@ export def "random-list bool" [
if $bias < 0 or $bias > 1 {
throw-error "value_error" "must be between 0 and 1" (metadata $bias | get span)
}
if $list_length < 0 {
throw-error "value_error" "must be greater than 0" (metadata $list_length | get span)
if $list_length < 0 {
throw-error "value_error" "must not be negative" (metadata $list_length | get span)
}

1..$list_length | each {|it|
0..<$list_length | each {|it|
random bool --bias $bias
}
}
Expand All @@ -35,14 +36,14 @@ export def "random-list chars" [
list_length: int, # A length of the list
--length (-l): int = 5 # A length of the string
] {
if $list_length < 0 {
throw-error "value_error" "must be greater than 0" (metadata $list_length | get span)
if $list_length < 0 {
throw-error "value_error" "must not be negative" (metadata $list_length | get span)
}
if $length < 0 {
throw-error "value_error" "must be greater than 0" (metadata $length | get span)
if $length < 0 {
throw-error "value_error" "must not be negative" (metadata $length | get span)
}

1..$list_length | each {|it|
0..<$list_length | each {|it|
random chars --length $length
}
}
Expand All @@ -52,11 +53,11 @@ export def "random-list float" [
list_length: int, # A length of the list
--range (-r): range # A range of the value
] {
if $list_length < 0 {
throw-error "value_error" "must be greater than 0" (metadata $list_length | get span)
if $list_length < 0 {
throw-error "value_error" "must not be negative" (metadata $list_length | get span)
}

1..$list_length | each {|it|
0..<$list_length | each {|it|
random float $range
}
}
Expand All @@ -67,17 +68,17 @@ export def "random-list dice" [
--roll-count (-r): int = 6, # A roll count
--side-count (-s): int = 6 # A side count
] {
if $list_length < 0 {
throw-error "value_error" "must be greater than 0" (metadata $list_length | get span)
if $list_length < 0 {
throw-error "value_error" "must not be negative" (metadata $list_length | get span)
}
if $roll_count < 0 {
throw-error "value_error" "must be greater than 0" (metadata $roll_count | get span)
if $roll_count < 1 {
throw-error "value_error" "must be at least 1" (metadata $roll_count | get span)
}
if $side_count < 0 {
throw-error "value_error" "must be greater than 0" (metadata $side_count | get span)
if $side_count < 2 {
throw-error "value_error" "must be at least 2" (metadata $side_count | get span)
}

1..$list_length | each {|it|
0..<$list_length | each {|it|
random dice --dice $roll_count --sides $side_count
}
}
Expand All @@ -87,11 +88,11 @@ export def "random-list int" [
list_length: int # A length of the list
--range (-r): range # A range of the value
] {
if $list_length < 0 {
throw-error "value_error" "must be greater than 0" (metadata $list_length | get span)
if $list_length < 0 {
throw-error "value_error" "must not be negative" (metadata $list_length | get span)
}

1..$list_length | each {|it|
0..<$list_length | each {|it|
random int $range
}
}
Expand All @@ -100,11 +101,11 @@ export def "random-list int" [
export def "random-list uuid" [
list_length: int # A length of the list
] {
if $list_length < 0 {
throw-error "value_error" "must be greater than 0" (metadata $list_length | get span)
if $list_length < 0 {
throw-error "value_error" "must not be negative" (metadata $list_length | get span)
}

1..$list_length | each {|it|
0..<$list_length | each {|it|
random uuid
}
}
Loading