Repository navigation
Conversation
Pull request dashboard statusWaiting on the author · refreshed 2026-10-21 17:25 UTC Respond to 1 review item (e.g. link a commit, explain why not, ask a follow-up):
Status above doesn't look right?
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8935 +/- ##
============================================
- Coverage 90.43% 90.42% -0.01%
- Complexity 10908 10909 +1
============================================
Files 1015 1015
Lines 29854 29858 +4
Branches 3901 3902 +1
============================================
+ Hits 26998 26999 +1
- Misses 1907 1908 +1
- Partials 949 951 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Couple of thoughts:
|
Let me know your thoughts on this. cc: @jack-berg , @dashpole |
|
Hi @psx95 — just a friendly reminder that this pull request is waiting on you. The dashboard status comment has the open items and is kept current.
|
Just waiting on the spec PR to officially support the proposed env var here. Once this PR is merged, we should be ok to merge this. |
9bc1f69 to
582ff05
Compare
Summary
Adds support for configuring
PeriodicMetricReaderBuilder#setMaxExportBatchSizeinopentelemetry-sdk-extension-autoconfigurevia theotel.experimental.metric.export.max.batch.sizesystem property (OTEL_EXPERIMENTAL_METRIC_EXPORT_MAX_BATCH_SIZEenvironment variable).Motivation / Justification
PeriodicMetricReaderBuilder#setMaxExportBatchSizewas added in #8296 and stabilized in #8829, and is supported in declarative configuration viamax_export_batch_size/development. However, users relying on environment variable / system property autoconfiguration (such as zero-code OpenTelemetry Javaagent users or Spring Boot starter users) currently have no way to configure metric export batching:otel.java.metrics.cardinality.limit) can hit OTLP payload / gRPC message size limits or collector/backend ingestion limits per export request without batching.max_export_batch_size/developmentonPeriodicMetricReaderModel, so declarative config remains a strict superset of env var / system property configuration./developmentinopentelemetry-configuration), it is namespaced underotel.experimental.*to avoid locking in a stable property name prematurely.Fix: #8936