To remove cross module internal utility usage from trace propagators by NithinU2802 · Pull Request #8955 · open-telemetry/opentelemetry-java

NithinU2802 · 2026-10-18T08:13:13Z

This PR is to resolves a part #6970 by updating the trace-propagators module’s dependency on API internal utility classes.

Changes

Add trace-propagators local StringUtils and TemporaryBuffers utilities.
Update B3, Jaeger, and OT trace propagators to use the local utilities which are created.
Add explicit null accordingly to the files.
Did pick methods which are used from the API internal utility classes.

opentelemetry-pr-dashboard · 2026-10-18T08:13:31Z

Pull request dashboard status

Waiting on the author · refreshed 2026-10-23 20:25 UTC

Investigate required status check failures.

Status above doesn't look right?

Just replied or pushed? Anything around or after the refresh time above may not be picked up yet — give it a few minutes.
Should this be with reviewers? Comment /dashboard route:reviewers to route it to them.
Anything wrong — including the routing? Report it with what you expected; it helps us improve the dashboard.

…ving only api internal utils

codecov · 2026-10-18T08:40:13Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.42%. Comparing base (877820b) to head (655ddd2).

Additional details and impacted files

@@            Coverage Diff            @@
##               main    #8955   +/-   ##
=========================================
  Coverage     90.41%   90.42%           
- Complexity    10981    10992   +11     
=========================================
  Files          1019     1020    +1     
  Lines         30016    30026   +10     
  Branches       3917     3920    +3     
=========================================
+ Hits          27140    27151   +11     
- Misses         1923     1924    +1     
+ Partials        953      951    -2

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

jack-berg · 2026-10-19T18:46:04Z

+   * @param minLength the minimum length of the returned string
+   * @return the padded string, or {@code value} if it already meets the minimum length
+   */
+  static String padLeft(String value, int minLength) {


I think this is only used in the opentelemetry-extension-trace-propagators module and tests, so let's go ahead and remove it from io.opentelemetry.api.internal.StringUtils.

This method is also used here in SdkLoggerTest.java, Line 79

jack-berg · 2026-10-19T18:46:42Z

+   * @param string the string to check
+   * @return {@code true} if {@code string} is {@code null} or empty
+   */
+  static boolean isNullOrEmpty(@Nullable String string) {


I think this method is kind of silly. Better to just enumerate the string == null || string.isEmpty() condition in the places that use it.

jack-berg · 2026-10-19T18:51:55Z

+ * <p>This class is internal and is hence not for public use. Its APIs are unstable and can change
+ * at any time.
+ */
+final class TemporaryBuffers {


I think we should consider promoting this to a .impl. API since a second ThreadLocal increases the the allocation per thread when reuse is safe

yeah ok, I will move this TemporaryBuffers to api.impl and update the imports accordingly to follow this approach which avoid additional ThreadLocal creation.

otelbot · 2026-10-20T04:18:50Z

⚠️ API changes detected — additional maintainer review required

@jack-berg @jkwatson

This PR modifies the public API surface area of the following module(s):

opentelemetry-api

Please review the changes in docs/apidiffs/current_vs_latest/ carefully before approving.

…propagator

…hub.com/NithinU2802/opentelemetry-java into fix/trace-propagator-internal-utilities

… tests for common

jkwatson · 2026-10-22T18:27:47Z

+++  NEW CLASS: PUBLIC(+) FINAL(+) io.opentelemetry.api.impl.TemporaryBuffers  (not serializable)
+	+++  CLASS FILE FORMAT VERSION: 52.0 <- n.a.
+	+++  NEW SUPERCLASS: java.lang.Object
+	+++  NEW METHOD: PUBLIC(+) STATIC(+) char[] chars(int)


fix: to remove trace propagators use of api internal utilities

bc61372

NithinU2802 requested a review from a team as a code owner October 18, 2026 08:13

opentelemetry-pr-dashboard Bot mentioned this pull request Oct 18, 2026

Pull Request Dashboard #8439

Open

fix: to restore trace propagators in NoSharedInternalCodeTest as remo…

fd873d4

…ving only api internal utils

jack-berg reviewed Oct 19, 2026

View reviewed changes

NithinU2802 added 3 commits October 20, 2026 09:03

fix: to update inline null or empty string checks

50508cd

refactor: to move temporarybuffer to api.impl with imports update

d285917

patch: update apidiffs as per the guidance

4323448

otelbot Bot added the api-change Changes to public API surface area label Oct 20, 2026

NithinU2802 and others added 5 commits October 20, 2026 09:50

Merge branch 'main' into fix/trace-propagator-internal-utilities

9b956d8

test: to cover stringutils and empty trace/span id for jaeger and b3 …

a5ee03c

…propagator

Merge branch 'fix/trace-propagator-internal-utilities' of https://git…

8d1630e

…hub.com/NithinU2802/opentelemetry-java into fix/trace-propagator-internal-utilities

fix: to revert the snapshot versions of apidiffs changes

bd4b16d

fix and test: jaegerpropagator remove split values null check and add…

930e0a9

… tests for common

NithinU2802 requested a review from jack-berg October 20, 2026 07:02

NithinU2802 and others added 2 commits October 22, 2026 08:50

Merge branch 'main' into fix/trace-propagator-internal-utilities

b2e452e

fix: restructure of opentelemetry-api.txt

655ddd2

jkwatson reviewed Oct 22, 2026

View reviewed changes

Navigation Menu

Repository navigation

To remove cross module internal utility usage from trace propagators - #8955

To remove cross module internal utility usage from trace propagators#8955
NithinU2802 wants to merge 12 commits into
open-telemetry:mainfrom
NithinU2802:fix/trace-propagator-internal-utilities

NithinU2802 commented Oct 18, 2026 •

edited

Loading

Uh oh!

opentelemetry-pr-dashboard Bot commented Oct 18, 2026 •

edited

Loading

Uh oh!

codecov Bot commented Oct 18, 2026 •

edited

Loading

Uh oh!

jack-berg Oct 19, 2026

Uh oh!

NithinU2802 Oct 20, 2026

Uh oh!

jack-berg Oct 19, 2026

Uh oh!

NithinU2802 Oct 20, 2026

Uh oh!

jack-berg Oct 19, 2026

Uh oh!

NithinU2802 Oct 20, 2026

Uh oh!

otelbot Bot commented Oct 20, 2026

Uh oh!

jkwatson Oct 22, 2026

Uh oh!

This branch has not been deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

NithinU2802 commented Oct 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Uh oh!

opentelemetry-pr-dashboard Bot commented Oct 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull request dashboard status

Uh oh!

codecov Bot commented Oct 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

jack-berg Oct 19, 2026

Choose a reason for hiding this comment

Uh oh!

NithinU2802 Oct 20, 2026

Choose a reason for hiding this comment

Uh oh!

jack-berg Oct 19, 2026

Choose a reason for hiding this comment

Uh oh!

NithinU2802 Oct 20, 2026

Choose a reason for hiding this comment

Uh oh!

jack-berg Oct 19, 2026

Choose a reason for hiding this comment

Uh oh!

NithinU2802 Oct 20, 2026

Choose a reason for hiding this comment

Uh oh!

otelbot Bot commented Oct 20, 2026

⚠️ API changes detected — additional maintainer review required

Uh oh!

jkwatson Oct 22, 2026

Choose a reason for hiding this comment

Uh oh!

This branch has not been deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

NithinU2802 commented Oct 18, 2026 •

edited

Loading

opentelemetry-pr-dashboard Bot commented Oct 18, 2026 •

edited

Loading

codecov Bot commented Oct 18, 2026 •

edited

Loading