Skip to content

Fix hexadecimal flag parsing in Jaeger propagator - #8975

Open
kamikazeayoup wants to merge 1 commit into
open-telemetry:mainfrom
kamikazeayoup:fix/jaeger-hex-flags
Open

kamikazeayoup wants to merge 1 commit into
open-telemetry:mainfrom
kamikazeayoup:fix/jaeger-hex-flags

Conversation

@kamikazeayoup

Copy link
Copy Markdown
Contributor

Problem

The Jaeger propagation format (https://www.jaegertracing.io/sdk-migration/#tracespan-identity) defines flags as one or two hexadecimal digits, but the propagator parses them as decimal.

Valid values such as b (sampled, debug, and firehose enabled) fail to parse, causing the incoming trace context to be lost.

Changes

  • Parse flags using base 16.
  • Add a regression test using the Jaeger client’s encoder to verify that flags b produce a valid, sampled remote context.

Validation

The regression test fails without the fix and passes with it.

@kamikazeayoup
kamikazeayoup requested a review from a team as a code owner October 22, 2026 00:18
@opentelemetry-pr-dashboard

opentelemetry-pr-dashboard Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Pull request dashboard status

Waiting on reviewers · refreshed 2026-10-24 18:25 UTC

Review the latest changes.

Status above doesn't look right?
  • Just replied or pushed? Anything around or after the refresh time above may not be picked up yet — give it a few minutes.
  • Anything look wrong? Report it with what you expected; it helps us improve the dashboard.

@codecov

codecov Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.41%. Comparing base (877820b) to head (5290af3).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #8975      +/-   ##
============================================
- Coverage     90.41%   90.41%   -0.01%     
+ Complexity    10981    10980       -1     
============================================
  Files          1019     1019              
  Lines         30016    30016              
  Branches       3917     3917              
============================================
- Hits          27140    27139       -1     
  Misses         1923     1923              
- Partials        953      954       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant