Repository navigation
Fix hexadecimal flag parsing in Jaeger propagator - #8975
Open
kamikazeayoup wants to merge 1 commit into
Open
kamikazeayoup wants to merge 1 commit into
kamikazeayoup wants to merge 1 commit into
Conversation
Pull request dashboard statusWaiting on reviewers · refreshed 2026-10-24 18:25 UTC Review the latest changes. Status above doesn't look right?
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8975 +/- ##
============================================
- Coverage 90.41% 90.41% -0.01%
+ Complexity 10981 10980 -1
============================================
Files 1019 1019
Lines 30016 30016
Branches 3917 3917
============================================
- Hits 27140 27139 -1
Misses 1923 1923
- Partials 953 954 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Jaeger propagation format (https://www.jaegertracing.io/sdk-migration/#tracespan-identity) defines flags as one or two hexadecimal digits, but the propagator parses them as decimal.
Valid values such as b (sampled, debug, and firehose enabled) fail to parse, causing the incoming trace context to be lost.
Changes
Validation
The regression test fails without the fix and passes with it.