[Prash88]

Steps to repro

In Example app,

Tap sign in, hit continue.
Move the app to the background.
Go to Settings > Safari > Clear History and Website Data.
Go into the app again. A new permission dialog is shown.
Tap Cancel. App crashes.

Recording from example app: https://streamable.com/5m16cx

Reasons for crash

The crash happens because of ASWebAuthenticationSession getting deallocated during or immediately after completion handler
http://ww.openradar.appspot.com/FB12132525

Fix explanation

As suggested, this crash can be mitigated by intentionally retaining the authentication session until after the dismiss animation is complete.

[camden-king]

Verified the crash described occurs in iOS example app with Okta and that the proposed fix prevents the crash.

[brnnmrls]

@Prash88 Do you mind fixing the failing tests, please?

[Lomaas]

Why isn't this merged? @Prash88

[w-goog]

Thank you for the bump, Simen! We'll get this in the next minor release on a fresh branch (if anyone wants to toss that up, that would speed things along; otherwise I'll handle it 💖)

[AndreasVerhoeven]

Will this ever get merged? This is the #1 crasher in our app :(

[w-goog]

Hi Andreas! We will still get to this in the next minor release, on a fresh branch, as the extant PR is not suitable. I'm sorry that I don't have a firmer timeline for you than "coming soon". (Fortunately, with Cocoapods being deprecated, soon will be "quite soon" :)).

[w-goog]

Thank you for this, Prashanth! The fix landed as #985 on a fresh branch, and it'll ship in 3.1.0 (you're credited in the CHANGELOG). Closing this one in favour of it.

(Thanks also to Simen & Andreas for the bumps.)