Skip to content

OCPBUGS-105402: Remove EVPN feature gate - #3003

Open
dasanind wants to merge 1 commit into
openshift:masterfrom
dasanind:OCPBUGS-105402
Open

OCPBUGS-105402: Remove EVPN feature gate#3003
dasanind wants to merge 1 commit into
openshift:masterfrom
dasanind:OCPBUGS-105402

Conversation

@dasanind

Copy link
Copy Markdown

chore: OCPBUGS-105402: Remove EVPN feature gate

The EVPN feature gate has been enabled by default and is no longer needed within the product. All clusters now have EVPN functionality available without requiring an explicit feature gate.
This commit removes:

  • FeatureGateEVPN definition from features/features.go
  • EVPN references from all payload manifest files
  • EVPN entry from features.md documentation

The feature gate graduation is complete and the gate is no longer required for cluster configuration.

The EVPN feature gate has been enabled by default and is
no longer needed within the product. All clusters now have
EVPN functionality available without requiring an explicit
feature gate.
This commit removes:
- FeatureGateEVPN definition from features/features.go
- EVPN references from all payload manifest files
- EVPN entry from features.md documentation

The feature gate graduation is complete and the gate is no
longer required for cluster configuration.

Signed-off-by: Anindita Das <anidas@redhat.com>
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 21, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@dasanind: This pull request references Jira Issue OCPBUGS-105402, which is invalid:

  • expected the bug to target the "5.1.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

chore: OCPBUGS-105402: Remove EVPN feature gate

The EVPN feature gate has been enabled by default and is no longer needed within the product. All clusters now have EVPN functionality available without requiring an explicit feature gate.
This commit removes:

  • FeatureGateEVPN definition from features/features.go
  • EVPN references from all payload manifest files
  • EVPN entry from features.md documentation

The feature gate graduation is complete and the gate is no longer required for cluster configuration.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci

openshift-ci Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Hello @dasanind! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@coderabbitai

coderabbitai Bot commented Aug 21, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 37d5db0f-ffd2-41b3-b8c0-a6be5cb363bd

📥 Commits

Reviewing files that changed from the base of the PR and between 3db6c4b and 9348b83.

📒 Files selected for processing (12)
  • apps/v1/generated.proto
  • build/v1/generated.proto
  • features.md
  • features/features.go
  • payload-manifests/featuregates/featureGate-4-10-Hypershift-Default.yaml
  • payload-manifests/featuregates/featureGate-4-10-Hypershift-DevPreviewNoUpgrade.yaml
  • payload-manifests/featuregates/featureGate-4-10-Hypershift-OKD.yaml
  • payload-manifests/featuregates/featureGate-4-10-Hypershift-TechPreviewNoUpgrade.yaml
  • payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-Default.yaml
  • payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-DevPreviewNoUpgrade.yaml
  • payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-OKD.yaml
  • payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-TechPreviewNoUpgrade.yaml
💤 Files with no reviewable changes (10)
  • payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-DevPreviewNoUpgrade.yaml
  • payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-TechPreviewNoUpgrade.yaml
  • features.md
  • payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-OKD.yaml
  • payload-manifests/featuregates/featureGate-4-10-Hypershift-OKD.yaml
  • payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-Default.yaml
  • features/features.go
  • payload-manifests/featuregates/featureGate-4-10-Hypershift-DevPreviewNoUpgrade.yaml
  • payload-manifests/featuregates/featureGate-4-10-Hypershift-Default.yaml
  • payload-manifests/featuregates/featureGate-4-10-Hypershift-TechPreviewNoUpgrade.yaml

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.


📝 Walkthrough

Walkthrough

The protobuf definitions in apps/v1 and build/v1 now include gogoproto package options and field annotations for generated names, nullability, casts, marshaling, sizing, unmarshaling, getters, and stringer behavior. Protobuf field numbers and wire types remain unchanged. The EVPN feature row, Go feature-gate registration, and EVPN entries in 4.10 feature-gate manifests were removed.

Merge Risk: ⚪ Minimal · up to 9348b

This change removes the obsolete EVPN feature gate and its references from manifests and documentation. No actionable merge-blocking risk remains beyond normal checks and review.

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely identifies the main change: removing the EVPN feature gate.
Description check ✅ Passed The description explains why the EVPN feature gate is removed and identifies the affected files and configuration references.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.)
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The PR changes only protobuf metadata, feature registration, documentation, and YAML manifests; no test source or Ginkgo title declaration changed.
Test Structure And Quality ✅ Passed The PR changes only two .proto files, documentation, feature registration, and YAML manifests; the diff has zero *_test.go paths and no Ginkgo test changes.
Microshift Test Compatibility ✅ Passed The pull request adds no Ginkgo tests or test files; it changes only protobuf definitions, feature documentation, Go registration, and YAML manifests.
Single Node Openshift (Sno) Test Compatibility ✅ Passed The PR diff adds no Ginkgo e2e tests or test files; it only changes protobuf, feature metadata, and YAML manifests, so the SNO test check is not triggered.
Topology-Aware Scheduling Compatibility ✅ Passed Changed YAML objects are FeatureGate resources and only remove EVPN; protobuf edits add gogoproto annotations. No scheduling constraint or topology assumption is introduced.
Ote Binary Stdout Contract ✅ Passed The diff adds no main, init, suite setup, stdout, klog, or logging writes; the only Go change deletes FeatureGateEVPN, while other changes affect protobuf options and manifests.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The parent-to-HEAD diff adds no Ginkgo tests or test code; it changes only protobuf annotations, feature metadata, and manifests, so this check is inapplicable.
No-Weak-Crypto ✅ Passed Pull request removes EVPN feature gate and adds gogo protobuf annotations. No weak cryptographic algorithms, custom crypto implementations, or insecure secret comparisons were introduced.
Container-Privileges ✅ Passed The PR diff adds no privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, root, or allowPrivilegeEscalation settings; changed manifests only remove EVPN entries.
No-Sensitive-Data-In-Logs ✅ Passed The diff adds only protobuf metadata and removes EVPN configuration. It adds no logging calls or sensitive values; generated Go implementations remain unchanged.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 Buf (1.72.0)
apps/v1/generated.proto

fatal: unable to access 'https://github.com/openshift/api.git/': Failed to connect to github.com port 443 via 127.0.0.1 after 0 ms: Could not connect to server
fatal: could not fetch 875137c1a8606b89749b3dd26889a16996b51fc6 from promisor remote

build/v1/generated.proto

fatal: unable to access 'https://github.com/openshift/api.git/': Failed to connect to github.com port 443 via 127.0.0.1 after 0 ms: Could not connect to server
fatal: could not fetch 875137c1a8606b89749b3dd26889a16996b51fc6 from promisor remote


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci openshift-ci Bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 21, 2026
@openshift-ci

openshift-ci Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dasanind

Copy link
Copy Markdown
Author

/jira refresh

@openshift-ci-robot

Copy link
Copy Markdown

@dasanind: This pull request references Jira Issue OCPBUGS-105402, which is invalid:

  • expected the bug to target either version "5.1.0." or "openshift-5.1.0.", but it targets "5.0.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci

openshift-ci Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

@dasanind: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/verify-feature-promotion 9348b83 link true /test verify-feature-promotion
ci/prow/verify 9348b83 link true /test verify

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@everettraven

Copy link
Copy Markdown
Contributor

/pipeline auto

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification

The pipeline-auto label has been added to this PR. Second-stage tests will be triggered automatically when all first-stage tests pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. pipeline-auto size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants