Repository navigation
Added feature for story cleaning - #92
thatgirlginger wants to merge 4 commits into
Conversation
hlieberman
left a comment
hlieberman
left a comment
There was a problem hiding this comment.
Definitely will be a help on some of the non-EF imports.
| @@ -0,0 +1,72 @@ | |||
| class Keywords: | |||
| def __init__(self): | |||
| self.notes = [ | |||
There was a problem hiding this comment.
Rather than list all combinations of cases, we could do a case-insensitive match later.
There was a problem hiding this comment.
can definitely do that.
i was also thinking about adding another config argument with more specific keywords, since this is one of those things that can vary a lot between archives. (in my own branch the notes keyword list alone has doubled).
do you think adding additional optional info in the YAML for this case would be ideal? i don't want anything to get too confusing or too bulky, but i also don't want to make the configuration too confusing
There was a problem hiding this comment.
I think my general rule is that things which require human intervention should be passed on the command line or in an interactive session, whereas things which will never change could go into config. So additional keywords, yeah, I could see that going into the config. But we'd want to be clear in the example config that they're optional and only used for this script.
| @@ -0,0 +1,50 @@ | |||
| from colorama import Fore, Style | |||
There was a problem hiding this comment.
This is a new library to this repo, so it needs to be added to the requirements.txt.
2 participants
cleaned and added feature for aid in story cleaning with custom archives where notes and summaries might be in the main body of text