Repository navigation
Re-encode the URI for the SAML redirect link - #3406
Merged
Merged
Conversation
On the SAML login page, when we pull out the redirect_uri from the url for the redirect link, it's decoded automatically. When the URI is just a path, like `/system`, the decoded form on Nexus' end is still a valid URI. But if there's a sufficiently complex query, with things like whitespace (or, say, OxQL comparison operators), Nexus will rightly refuse to parse that after decoding. Simple enough; just re-encode it!
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
david-crespo
approved these changes
Oct 10, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On the SAML login page, when we pull out the redirect_uri from the url for the redirect link, it's decoded automatically. When the URI is just a path, like
/system, the decoded form on Nexus' end is still a valid URI. But if there's a sufficiently complex query, with things like whitespace (or, say, OxQL comparison operators), Nexus will rightly refuse to parse that after decoding. Simple enough; just re-encode it!