Repository navigation
Fix visual regression false positives due to UUID truncation race - #3407
Merged
Merged
Conversation
Canvas measureText uses fallback font metrics until the web font loads, and the font swap doesn't necessarily resize the container, so the ResizeObserver never fired and the truncation stayed computed against the fallback font. This made truncated UUIDs nondeterministic, which showed up as false positives in the visual regression suite.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
david-crespo
changed the title
david-crespo
enabled auto-merge (squash)
October 10, 2026 16:41
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Canvas measureText uses fallback font metrics until the web font loads, and the font swap doesn't necessarily resize the container, so the truncation stayed computed against the fallback font. This made truncated UUIDs nondeterministic, which showed up as false positives in the visual regression suite.