Repository navigation
Conversation
Feature name 'preserve_order' used to stay consistent with `serde_json`.
Collaborator
|
I have not yet looked at the code, but do you think this is best as a crate feature or as a runtime setting? I could see the latter potentially making sense given that there are other flags that affect code generation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adapts the property sorting for structs from the sanitized names to the original ones set in the schema. e.g. common properties such as
$schemaare now sorted starting with$instead ofs.With this ordering, serializing will create JSON content with correctly sorted properties (excluding generic maps).
Downside is that properties of Rust structs may not be alphabetically ordered.
Added the feature
preserve_order, to keep the property order as set in the JSON schema.This requires that deserialization is done in a way that preserves ordering, which
serde_jsondoes with the samepreserve_orderfeature flag.