Skip to content

Synchronize graphical node moves with model positions - #533

Open
Rajvira10 wants to merge 1 commit into
paceholder:masterfrom
Rajvira10:fix/synchronize-node-positions
Open

Rajvira10 wants to merge 1 commit into
paceholder:masterfrom
Rajvira10:fix/synchronize-node-positions

Conversation

@Rajvira10

Copy link
Copy Markdown

Type of change

  • Bug fix

Description

Moving nodes updates their graphics without storing the new model coordinates or emitting the completed-move signal. Synchronize graphical position changes with the model, avoiding duplicate updates when the model initiates the move.

Testing

Qt version tested: 6.11.2. Eleven regression assertions fail on unchanged upstream; 37 selected tests (448 assertions) pass after the fix. The library, all configured examples and changed-code formatting checks pass.

  • Added tests for dragging, grouped moves, save/load and notification counts.
  • Full existing suite: remaining UI/stress tests and Qt 5 were not run.

Breaking changes?

None.

Related issue

Fixes #525. Fixes #526.

@Rajvira10
Rajvira10 marked this pull request as ready for review October 16, 2026 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

setNodeData no longer called when a node is moved public API broken: BasicGraphicsScene::nodeMoved is not emitted anymore

1 participant