Repository navigation
feat(forms): open the field of a lint finding from its path - #279
Merged
Merged
Conversation
A lint finding showed its field path as plain text, so there was no way to get from a finding to the field it is about. The path is now a Show field button, named "Show field <path>", that opens the field the same way an Error summary entry does: it switches to the Fields view, clears filters only when they hide the row, opens the field detail and focuses its heading. Findings about the whole form stay plain text. The lint component emits a showField output that the Forms page wires to its existing showField(path). The summary-link styles move into the shared forms styles so both lists use one definition, and their focus style uses the m.focus-ring mixin instead of a hand-written outline. The Lint section of the Forms docs page describes the new link.
github-actions
Bot
added
area: panel
Contributor
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
⛔ Files ignored due to path filters (1)
📒 Files selected for processing (4)
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to Field findings navigate to their details, and the updated bundle references are consistent. No actionable merge risk remains beyond normal checks. Pre-merge checks |
  |
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage |  |
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 5 files. (2 skipped: 2 … | Write docstrings for the functions missing them to satisfy the coverage threshold. |
✅ Passed checks (4 passed)
-
-
Check name Status Explanation Description Check Check skipped - CodeRabbit’s high-level summary is enabled. Title check The title clearly and concisely describes the main change: opening the field associated with a Forms lint finding from its path. Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request.
-
Full details: Docstring Coverage
-
-
Explanation
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 5 files. (2 skipped: 2 unsupported.)
-
- Fix all pre-merge checks with AI
✨ Finishing Touches
-
📝 Generate docstrings
-
-
-
-
- Commit to this branch
- Create a new PR
-
-
-
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
🚀 Deploying Preview to Cloudflare 🚀Preview Deployments by commit
|
# Conflicts: # extension/ui/assets/browser-agent-rpc-BXhoSh1z-CFmADKyK.js # extension/ui/assets/browser-agent-rpc-BXhoSh1z-CQUbrXfP.js # extension/ui/assets/browser-agent-rpc-BXhoSh1z-uMKjpgxH.js # extension/ui/assets/index-Bu2QP0tv.js # extension/ui/assets/index-CgvJVwtz.js # extension/ui/assets/index-RHlVGXjX.js # extension/ui/index.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Forms Lint findings showed their field path as plain text, so a finding could not take you to its field. The path is now a "Show field " button that reuses the Error summary behaviour: it switches to the Fields view, clears filters only when they hide the row, opens the field detail and moves focus to its heading. Findings about the whole form have no path and stay plain text.
FormsLintemits ashowFieldoutput, wired to the existingFormsInspector.showField(path)..summary-linkstyles move into the shared forms styles so the Error summary and Lint share one definition; the focus style now uses them.focus-ringmixin.How it was verified
pnpm format:checkpnpm typecheck(andngc -p app/tsconfig.json --noEmit: 0 errors)pnpm test:panel(244 passed; two tests added that fail without the change)pnpm docs:buildpnpm extension:build,extension/uicommittedpnpm commit:checkscripts/panel-axe.mjson the static report: 29/29 views, 0 violationsScreenshots
None attached.
Notes for reviewers
node.path), and root findings send no path..path codecolor is gone; the path now uses the shared accent link style.forms-inspector.tslike fix(ui): keep focus on the filter box after Clear filters #278 (Escape on the fields filter), so whichever merges second needs a small merge.Summary by CodeRabbit