Repository navigation
feat(pipes): select a pipe from its lint finding - #292
Merged
Merged
Conversation
A lint finding showed the pipe name as plain text, so reading its details meant typing the name into the search. The name is now a "Show pipe <name>" button when the pipe is in the list. It clears the search or Show pipes filter only when that filter hides the pipe, selects it, scrolls its row into view and moves focus to the detail heading. Findings for pipes that are not listed stay plain text. Updates the Lint section of the Pipes docs page and rebuilds extension/ui.
Contributor
🚀 Deploying Preview to Cloudflare 🚀Preview Deployments by commit
|
# Conflicts: # app/src/pages/pipes-inspector.ts # extension/ui/assets/browser-agent-rpc-BXhoSh1z-CFmADKyK.js # extension/ui/assets/browser-agent-rpc-BXhoSh1z-CQUbrXfP.js # extension/ui/assets/browser-agent-rpc-BXhoSh1z-DlWvzvAg.js # extension/ui/assets/index-CgvJVwtz.js # extension/ui/assets/index-MIHPPrL0.js # extension/ui/assets/index-RHlVGXjX.js # extension/ui/index.html
The merge with main changed the panel, so the committed bundle is rebuilt to match.
# Conflicts: # extension/ui/assets/browser-agent-rpc-BXhoSh1z-CFmADKyK.js # extension/ui/assets/browser-agent-rpc-BXhoSh1z-CSxlKyzP.js # extension/ui/assets/browser-agent-rpc-BXhoSh1z-DPWCK8mF.js # extension/ui/assets/index-CoOSAhs2.js # extension/ui/assets/index-RHlVGXjX.js # extension/ui/assets/index-cXWBDTJ3.js # extension/ui/index.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
In the Pipes tab, a Lint finding showed its pipe name as plain text. To see that pipe's details you had to type its name into the search. Now the name is a Show pipe button when the pipe is in the list. It clears the search or Show pipes filter only if that filter hides the pipe, selects the pipe, scrolls its row into view and moves focus to the detail heading, the same way Forms' "Show field" works. Findings for pipes that are not in the list stay plain text. The Lint section of the Pipes docs page describes this.
How it was verified
pnpm format:checkpnpm typecheck(no messages for the changed page)pnpm test:panel: 246 tests pass; the 4 new tests inpipes-lint-show.test.tsfail without the changepnpm test:devtools(1508 passed)pnpm docs:buildpnpm extension:build,extension/uicommittedscripts/panel-axe.mjs: 0 violations on every view, dark and lightpnpm commit:checkScreenshots
None attached.
Notes for reviewers
A finding's
fileis often the template where the pipe is used, not where it is declared. The button picks the listed pipe with the same name and file, or else the first listed pipe with that name. The filter logic was split intofitsKindandfitsQueryso the list and the button use the same rules. No RPC or data shape changes.Summary by CodeRabbit