Skip to content

chore: ignore Finder metadata and clarify template validation - #10

Open
coisa wants to merge 1 commit into
mainfrom
codex/consumer-template-skill
Open

coisa wants to merge 1 commit into
mainfrom
codex/consumer-template-skill

Conversation

@coisa

@coisa coisa commented Oct 20, 2026

Copy link
Copy Markdown
Contributor

Two Finder metadata files were still tracked, and DESIGN.md described only one approved Composer plugin and one rendering fixture. Remove the tracked .DS_Store files, ignore them repository-wide, and correct the validation instructions to cover both rendering fixtures and the existing llm/skills synchronization behavior.

The consumer skill is already integrated through #8 and recorded in the v2.2.0 changelog by #9. This follow-up preserves that implementation, including the remote verifier hardening and Skills CLI removal guidance; it does not duplicate the feature or its consumed change fragment. Composer dependencies and the published changelog remain unchanged.

Validation

  • composer validate --strict --no-plugins and git diff --cached --check passed.
  • Changelog 0.3.0 validates the remaining Finder cleanup fragment, including the committed contribution check with --since=origin/main.
  • git ls-files '*.DS_Store' returns no tracked Finder files; git check-ignore confirms both removed paths are ignored. Local Finder files were retained.
  • Both rendering fixtures were rerun on the reconciled source using PHP 8.5.11 and phpDocumentor shim 3.10.0: the existing fixture checks 14 generated pages; the consumer fixture checks homepage, nested guide, API, search and theme assets.

During the original consumer-skill preparation, official skills-ref 0.1.0 validation, checkout/clean-archive rendering, all nine archived skill files, isolated llm/skills 1.15.0 lifecycle checks, manual/Skills CLI copies and browser theme checks passed. Those are prior candidate results, not new implementation changes in this follow-up. Native activation/fresh-model performance and end-to-end DevTools workflow execution remain unverified. The remote installation guide retains its warning that a CLI removal report alone does not prove the canonical copy disappeared.

Issue #2 was separately validated and closed with its evidence comment.

No merge, release or deployment is requested.

@coderabbitai

coderabbitai Bot commented Oct 20, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 39 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 6d81c0df-245a-4049-861b-ad5b2b16d47b
📥 Commits

Reviewing files that changed from the base of the PR and between 238c8b4 and 2ab7be3.

⛔ Files ignored due to path filters: 2
  • guides/.DS_Store is excluded by !**/.DS_Store
  • guides/body/.DS_Store is excluded by !**/.DS_Store
📒 Files selected for processing: 3
  • .changelog/ignore-finder-metadata.md
  • .gitignore
  • DESIGN.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-20T20:31:33.810352Z 2ab7be3 PR opened
🔒 Security Review ✅ Completed 2026-10-20T20:32:41.748414Z 2ab7be3 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

Copy link
Copy Markdown
Contributor

Changelog

✅ Contribution check passed.

Head: 2ab7be37c71122f199e8b28202c7677b080d3f77

Base: 238c8b4c53e41b03ebfbadb0d3acb70030d0adbe

Contribution: 1 new valid fragment(s). Policy: ordinary.

  • ignore-finder-metadata.md — fixed, patch

    Remove tracked Finder metadata and ignore .DS_Store files throughout the repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant