Repository navigation
fix(downloader): skip OS packages when a binary is expected - #149
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
docs: note that OS packages are not selected for a binary A selected package downloads fine and only fails the installation with nothing extracted, after the release loop has ended, so an older release with an archive was never tried. Dropping packages at selection turns that release into "no matching asset" and the downloader moves on. Assisted-By: Claude Opus 5.5 <noreply@anthropic.com>
roxblnfk
force-pushed
the
fix/package-assets
branch
from
October 10, 2026 16:01
2601db8 to
58a514c
Compare
fix(downloader): skip snap, flatpak, msix, appx and nupkg packages too test(downloader): cover the fallback to an older release over a package docs: list every skipped package format and the new report lines Assisted-By: Claude Opus 5.5 <noreply@anthropic.com>
…to an older one docs: state that the package fallback reaches the 10 newest matching releases refactor(downloader): name the cap on tried releases test(downloader): cover the skipped OS packages line of the failure report The cap stays at 10: raising it to the API page size would load further release pages whenever the version constraint matches fewer releases. Assisted-By: Claude Opus 5.5 <noreply@anthropic.com>
…r repository test(downloader): cover which skipped releases the packages-only warning names The release that had only OS packages was remembered for the whole download, so a later repository, or a refetched release list, warned that a version had only OS packages while downloading that same or a newer version from elsewhere. Assisted-By: Claude Opus 5.5 <noreply@anthropic.com>
…se report docs(downloader): note that the packages-only release is kept per repository pass Assisted-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
<binary>is configured and the type is notphar), OS packages —.deb,.rpm,.apk,.snap,.flatpak,.msi,.msix,.msixbundle,.appx,.appxbundle,.nupkg,.dmg,.pkg— are no longer selected. A release that has only a package for the host now counts as "no matching asset", and the downloader moves on to an older release.OS packages are skipped because a binary is expected: ….<binary>, packages are still offered, so downloading a.debon purpose keeps working.Why?
A selected package downloaded fine and only failed the installation with
NothingExtracted. That happens after the downloader has returned, so older releases with atar.gzwere never tried and the wholegetfailed. Hit by roadrunner-php/cli#49 (VersionSelectionTest::fallsBackToOlderReleaseWhenNewestHasNoAssembly).Treating
NothingExtractedas an asset failure would also cover an archive without the binary, but it means moving the installation into the release loop. That is left for a separate change.Checklist