sapi/fuzzer: depend on PHP_BINARY_OBJS instead of PHP_SAPI_OBJS - #23394
Closed
Mrmaxmeier wants to merge 1 commit into
Closed
sapi/fuzzer: depend on PHP_BINARY_OBJS instead of PHP_SAPI_OBJS#23394Mrmaxmeier wants to merge 1 commit into
Mrmaxmeier wants to merge 1 commit into
Conversation
LamentXU123
approved these changes
Aug 22, 2026
LamentXU123
left a comment
LamentXU123
left a comment
Member
There was a problem hiding this comment.
Looks correct. @NattyNarwhal Can you take a look at this since you are recently working on sapi?
Member
|
More of a build system question, but it makes sense to me. |
Member
|
This should target 8.4 @Mrmaxmeier could you rebase this to 8.4? |
FUZZER_BUILD links $(PHP_BINARY_OBJS) (main/internal_functions_cli.lo), but the php-fuzz-* rules listed $(PHP_SAPI_OBJS) (main/internal_functions.lo) as a prerequisite. Building only the fuzzers from a clean tree therefore fails on the missing internal_functions_cli.lo. Match the prerequisites to what is linked, as the CLI, CGI, phpdbg and litespeed fragments already do. Assisted-By: Claude Opus 5
Mrmaxmeier
force-pushed
the
fuzzer-fix-makefile
branch
from
August 22, 2026 20:29
5401a02 to
9a4b037
Compare
Contributor
Author
Whoops, thanks! 🙂 |
LamentXU123
added a commit
that referenced
this pull request
Aug 22, 2026
* PHP-8.5: sapi/fuzzer: depend on PHP_BINARY_OBJS instead of PHP_SAPI_OBJS (#23394)
Member
|
Thank you! |
pull Bot
pushed a commit
to KornaPhp/php-src
that referenced
this pull request
Aug 22, 2026
* PHP-8.4: sapi/fuzzer: depend on PHP_BINARY_OBJS instead of PHP_SAPI_OBJS (php#23394)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
PHP's fuzzers currently fail to build when built in isolation:
This PR adjusts the dependency graph to include the missing steps.
Thanks!