Fix user.ini handling when the script directory prefixes doc_root - #23414
Open
iliaal wants to merge 1 commit into
Open
Fix user.ini handling when the script directory prefixes doc_root#23414iliaal wants to merge 1 commit into
iliaal wants to merge 1 commit into
Conversation
php_cgi_ini_activate_user_config() swapped the scan base when path was shorter than DOCUMENT_ROOT, so a script dir that prefixes doc_root never parsed .user.ini. Scan the tree only when path descends from doc_root; otherwise parse the current directory. Same change in sapi/cgi and sapi/fpm.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
php_cgi_ini_activate_user_config() swapped the scan base when the script directory was shorter than DOCUMENT_ROOT, so a prefixing script dir never loaded .user.ini. Scan the tree only when path descends from doc_root. Same change in sapi/cgi and sapi/fpm.