Fix unbounded write on negative star precision in format_converter - #23416
Open
iliaal wants to merge 1 commit into
Open
Fix unbounded write on negative star precision in format_converter#23416iliaal wants to merge 1 commit into
iliaal wants to merge 1 commit into
Conversation
A "%.*[diouxX]" conversion with a negative precision was only clamped to -1, which FIX_PRECISION() compares against a size_t: (size_t)-1 turns the zero-padding loop into an unbounded backward write through num_buf and the stack. Treat a negative star precision as omitted in format_converter() only; xbuf_format_converter() keeps -1 as the %H shortest-float sentinel used by serialize_precision.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A negative star precision was only clamped to -1, so FIX_PRECISION() treated it as SIZE_MAX and wrote backwards through the buffer. Treat omitted precision that way in format_converter() only. xbuf_format_converter() keeps -1 as the %H shortest-float sentinel used by serialize_precision.