Repository navigation
Conversation
TimWolla
changed the title
TimWolla
commented
Oct 15, 2026
| function sodium_crypto_xof_shake128_init(?int $domain = null): SodiumCryptoXofShake128State {} | ||
|
|
||
| function sodium_crypto_xof_shake128_update(string &$state, string $message): true {} | ||
| function sodium_crypto_xof_shake128_update(SodiumCryptoXofShake128State $state, string $message): void {} |
Member
Author
There was a problem hiding this comment.
Should $message also have #[\SensitiveParameter]?
TimWolla
commented
Oct 15, 2026
TimWolla
left a comment
TimWolla
left a comment
Member
Author
There was a problem hiding this comment.
Things likely missing:
- Either support or disallow cloning the state.
- Reject manual construction of state objects.
ndossche
reviewed
Oct 15, 2026
| if (out_len <= 0 || out_len > ZSTR_MAX_LEN) { | ||
| zend_argument_error(sodium_exception_ce, 2, "must be a positive integer"); | ||
|
|
||
| if (out_len <= 0) { |
Member
There was a problem hiding this comment.
Actually, you still need the check against ZSTR_MAX_LEN, otherwise you will have a buffer overflow opportunity down below.
ndossche
reviewed
Oct 15, 2026
| } | ||
| if (out_len <= 0 || out_len > ZSTR_MAX_LEN) { | ||
| zend_argument_error(sodium_exception_ce, 1, "must be a positive integer"); | ||
| if (out_len <= 0) { |
Member
There was a problem hiding this comment.
Same here with the length check, and in a few other places. I'm not gonna mark them all
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative to #24182.