Repository navigation
Conversation
Contributor
Author
|
The FreeBSD job fails because the FreeBSD 13 package mirror returns 404. It fails the same way on other PRs today, so my change does not cause it. |
LamentXU123
approved these changes
Oct 15, 2026
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHP_MINIT_FUNCTION(date)registered its INI entries before resettingphp_date_global_timezone_db. Registeringdate.timezonerunsOnUpdate_date_timezone(), which checks the value againstDATE_TIMEZONEDB. On an in-process engine restart (Apache graceful reload, FrankenPHP worker restart), that pointer still points into the PECL timezonedb.sothat the previous shutdown unloaded, so startup reads unmapped memory and crashes inseek_to_tz_position(). The reset now happens beforeREGISTER_INI_ENTRIES().I checked it with a small embed host on macOS: it loads timezonedb as a shared extension, calls
php_embed_init()/php_embed_shutdown()twice, and maps aPROT_NONEregion over the address range the unloaded.soused. Before the fix, the second startup crashes inseek_to_tz_position(). After the fix, it starts normally and still uses the external database. There is no test, because run-tests cannot restart the engine inside one process.Fixes GH-24350